Code quality issues found by codacy #866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nefarius2001 can you check if this breaks your build? If it doesn't you should include these changes in your code. |
|
I think we should close this PR and wait until Android works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested mainly "my" code with codacy and found a few issues. Mainly they are related to wrong/missing quoting or wrong PowerShell verbs (didn't know something like this exists...): https://gist.github.com/Odepax/645634b1a2ec307b05f5cbc48e17c699
The code builds and creates binary releases; therefore everything should work fine. The executables haven't been tested but I didn't change anything.