Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoother surface for the fancy background #971

Merged
merged 3 commits into from
Feb 9, 2021
Merged

smoother surface for the fancy background #971

merged 3 commits into from
Feb 9, 2021

Conversation

passing
Copy link
Contributor

@passing passing commented Feb 8, 2021

solves #970

@ann0see ann0see linked an issue Feb 9, 2021 that may be closed by this pull request
@ann0see
Copy link
Member

ann0see commented Feb 9, 2021

Thanks for your first PR! @jamulussoftware/designers I think that's something for you.

Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Could you please also add an entry in the ChangeLog file and your name to the contributors file in the Jamulus software?

See this commit: b2a09f4#diff-25a6634263c1b1f6fc4697a04e2b9904ea4b042a89af59dc93ec1f5d44848a26

@ann0see
Copy link
Member

ann0see commented Feb 9, 2021

Great! Thanks.

@passing
Copy link
Contributor Author

passing commented Feb 9, 2021

@ann0see I have updated changelog and contributors list

Thanks for your first PR! @jamulussoftware/designers I think that's something for you.

Unfortunately, I cannot open that link, it just gives me a 404 🤷‍♂️

@ann0see
Copy link
Member

ann0see commented Feb 9, 2021

Strange. For me it works

@gilgongo gilgongo merged commit b0f2369 into jamulussoftware:master Feb 9, 2021
@hoffie
Copy link
Member

hoffie commented Feb 9, 2021

@ann0see I have updated changelog and contributors list

Thanks for your first PR! @jamulussoftware/designers I think that's something for you.

Unfortunately, I cannot open that link, it just gives me a 404 man_shrugging

Same for me. I assume this is a Github permission thing. Also same for "maindevelopers" which I have seen mentioned elsewhere. Maybe also related to #932.

@passing passing deleted the background_renewal branch February 10, 2021 00:25
ann0see added a commit that referenced this pull request Jul 1, 2024
Update server CLI options link for issue #971
@pljones pljones added this to the Release 3.7.0 milestone Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

Fancy Skin Background is full of compression artifacts
5 participants