-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document basic JSON-RPC api in CLI options #724
Document basic JSON-RPC api in CLI options #724
Conversation
@dtinth could you please quickly review this? |
wiki/en/Include-Shared-Commands.md
Outdated
@@ -2,10 +2,13 @@ | |||
[comment]: # (This is an include file for use in multiple documents) | |||
|
|||
- `-h` or `--help` Display help text | |||
- `-i` or `--inifile` Set location of initialization file (overrides default) | |||
- `-i` or `--inifile` Set location of initialization file (overrides default) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spacing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And line 6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spacing is wrong in the whole file, I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the spaces get collapsed, anyway. And .md
and tables don't always get on...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MD tables should work?
wiki/en/Include-Shared-Commands.md
Outdated
- `-Q` or `--qos` Sets the quality of service DSCP value. Default is 128. Disable with 0. QoS is ignored by Windows. To enable it, [see this page](QOS-Windows) | ||
- `-t` or `--notranslation` Disable UI language translations | ||
- `-6` or `--enableipv6` Enable IPv6 addressing (IPv4 is always enabled) | ||
- `-v` or `--version` Output version information and exit | ||
- `-v` or `--version` Output version information and exit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spacing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my new push
ce02fd9
to
b9aed31
Compare
b9aed31
to
3bbcede
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least it's more visually appealing :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, looks great!
Co-authored-by: Thai Pangsakulyanont <dtinth@spacet.me>
Don't forget to add this to the man page. EDIT: I don't know how to |
Short description of changes
Adds the jsonrpc command line options.
Context: Fixes an issue? Related issues
Related to: #717 (at least a first step)
Status of this Pull Request
Ready for review
What is missing until this pull request can be merged?
Finished.
Does this need translation?
YES.
Checklist