Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed linter and small refactor #1

Closed
wants to merge 56 commits into from
Closed

Fixed linter and small refactor #1

wants to merge 56 commits into from

Conversation

zoetrope69
Copy link

Fixed the linter and moved some of you if statements into a switch statement.

I don't know a lot about Mocha so can't work out why the tests are failing though.

jamuus and others added 30 commits October 23, 2015 10:11
@jamuus
add parsing code for battery level
30d47a3
@jamuus
actually call callback with the parsed data
662b753
@jamuus
fix battery voltage level reading
9326d5a
@jamuus
remove logging
928032e
updated serial port
1590601
@Flinnja
Use versions of serialport abover 2.0.0 if available
dff3042
@deadprogram
Merge branch 'Flinnja-master'
bc1611d
@deadprogram
Corrections for Travis builds to include latest versions of Node.js u…
d7f59e6 
…p to 4.1
@deadprogram
Adds missing install info for Grunt to README
e239da3
@deadprogram
Add Node.js 4.2.x to Travis build
78a265a
@deadprogram
Add compatibility section to README
46a1a7e
@deadprogram
Update version to 0.4.0
66f27fa
@deadprogram
Update with Node.js 5.x+ build requirements.
39d4519
@deadprogram
Simplify Travis build
09c139d
@deadprogram
Correct command ID for readLocator and properly handle 0x00 did sync …
2cd953f 
…command responses
@dportalesr
sphero port as env variable
92b8ea6 
Updates Readme

updates Location example
@deadprogram
Merge pull request sphero-inc#34 from orbotix/feature/port-as-env-var
c9d42b3 
Use port as env variable in examples
@deadprogram
Remove extra line from example
605f095
@deadprogram
Update package.json to 0.4.1
7b0cb96
@deadprogram
Add version checking example
c4449c8
@deadprogram
Add Node.js 5.1 to Travis builds
472107b
@deadprogram
Adds detailed field output to examples
813a4ad
@deadprogram
Some info about setting up udev rule under Ubuntu
07f3b08
@bmidgley
add signed type to parser and use for locator
8ee8c9c
@deadprogram
Merge pull request sphero-inc#36 from bmidgley/signed-parser-type
26f373e 
add signed type to parser and use for locator
@deadprogram
Starting BLE integration using noble
8ad347b
@deadprogram
Can send commands to BLE connected Sphero robotic devices
f0250e5
@deadprogram
Cleanup as demanded by ESlint
195f078
@deadprogram
Allow BLE addresses with colons as returned by all the CLI tools
45f088f
@deadprogram
Reformat to remove all errors and warnings from ESLint
c12b398
deadprogram and others added 26 commits December 22, 2015 13:24
@deadprogram
Can send and receive command sync data
61c7cf5
@deadprogram
Cleanup syntax for ESLint
0e86e92
@deadprogram
Run update before anything else to help accomodate ongoing Travis mig…
4183546 
…ration
@deadprogram
Cannot run update (or anything else Travis related) using sudo
cd2964a
@deadprogram
More incantations to the CI system
d0d0aa6
@deadprogram
Allow existing noble peripheral to be passed into adaptor
834ac1a
@deadprogram
Remove pre-installed dependencies, so you can use with either BLE or …
cea04d7 
…Bluetooth Classic
@deadprogram
Adds connection scanning info for BLE devices
6e9a91a
@deadprogram
Cleanup logging and begin implmenting better test coverage for BLE in…
303876a 
…terface
@deadprogram
Remove cruft, thanks ESLint
0e53231
@deadprogram
Nicer formatting for missing dependency messages
edd0b1c
@deadprogram
Moves code example up to the top of README
1c1af5c
@deadprogram
Defaults to use SOP2.both by default
2d9a8a1
@deadprogram
Adds emitPacketErrors option (defaults to false) to not require devs …
b3ff7d4 
…to handle all packet errors
@deadprogram
Adds documentation to README on the emitPacketErrors option
aff227a
@deadprogram
Leading off with simple example
a792af6
@deadprogram
Update package version to 0.5.0
07c40df
@deadprogram
Updates to README as suggested by @rhencke and others on issue sphero…
8430db7 
…-inc#26
@deadprogram
Initial simplistic implementation of freefall event
b354efc
@deadprogram
Naive implementation of freefall/landing events
a39f506
@deadprogram
Removes ESLint errors
dfc9b62
@deadprogram
Update JSDocs for detectFreefall function
04e8ef6
@dportalesr
Merge pull request sphero-inc#39 from orbotix/feature/freefall
6df6bf8 
Looking good!
Merge branch 'master' of https://github.com/jamuus/sphero.js into fix…
6219890 
…es-connection-error-handling

* 'master' of https://github.com/jamuus/sphero.js:
  remove logging
  fix battery voltage level reading
  actually call callback with the parsed data
  add parsing code for battery level
  fix lint check
  fix mixup in error handling when opening a serialport connection
Passes linter, fixed whitespace
7071d97
Refactored if else statements into previous switch
5a798aa
@zoetrope69 zoetrope69 mentioned this pull request Jan 3, 2016
Open
@zoetrope69 zoetrope69 closed this Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zoetrope69 @jamuus @Flinnja @deadprogram @dportalesr @bmidgley