Removing testservice implementation and using stubserver #12
Conversation
…-error-flow, var-declaration
Optimising the code by fixing var-declaration, indent-error-flow, increment-decrement, superfluous-else
…low, increment-decrement, superfluous-else"
Revert "Optimising the code by fixing var-declaration, indent-error-flow, increment-decrement, superfluous-else"
| server, err := xds.NewGRPCServer(grpc.Creds(insecure.NewCredentials()), modeChangeOpt, xds.BootstrapContentsForTesting(bootstrapContents)) | ||
| if err != nil { | ||
| t.Fatalf("Failed to create an xDS enabled gRPC server: %v", err) | ||
| } | ||
| t.Cleanup(server.Stop) | ||
| testgrpc.RegisterTestServiceServer(server, &testService{}) | ||
| testgrpc.RegisterTestServiceServer(server, stub) |
There was a problem hiding this comment.
I think we should be doing something like:
stub := &stubserver.StubServer{
EmptyCallF: func(ctx context.Context, in *testpb.Empty) (*testpb.Empty, error) {
return &testpb.Empty{}, nil
},
UnaryCallF: func(ctx context.Context, in *testpb.SimpleRequest) (*testpb.SimpleResponse, error) {
return &testpb.SimpleResponse{}, nil
},
}
// Create the xDS-enabled gRPC server like how we are doing today
stub.S = server
stubserver.StartTestService(t, stub) // instead of manually registering the test service| @@ -161,7 +162,7 @@ func (s) TestServerSideXDS_WithNoCertificateProvidersInBootstrap_Failure(t *test | |||
| if err != nil { | |||
| t.Fatalf("Failed to create an xDS enabled gRPC server: %v", err) | |||
| } | |||
| testgrpc.RegisterTestServiceServer(server, &testService{}) | |||
| testgrpc.RegisterTestServiceServer(server, &stubserver.StubServer{}) | |||
| server, err := xds.NewGRPCServer(grpc.Creds(creds), modeChangeOpt, xds.BootstrapContentsForTesting(bootstrapContents)) | ||
| if err != nil { | ||
| t.Fatalf("Failed to create an xDS enabled gRPC server: %v", err) | ||
| } | ||
| testgrpc.RegisterTestServiceServer(server, &testService{}) | ||
| testgrpc.RegisterTestServiceServer(server, stub) |
|
I see that while some tests create an empty stub server like |
|
An empty stub server will give invalid memory address or nil pointer dereference right? How to approach these, please suggest. |
Ah, there is a check for |
|
Yes, there is a check for that. Sure will raise a PR on the main repo. Thanks for the confirmation. |
No description provided.