Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid amazon link #3151

Closed
webysther opened this issue Sep 17, 2024 · 3 comments · Fixed by #3163
Closed

Invalid amazon link #3151

webysther opened this issue Sep 17, 2024 · 3 comments · Fixed by #3163
Labels
bug Fixed in Nightly

Comments

@webysther
Copy link
Contributor

Describe the bug/problem

With this ID on calibre amazon_uk:0141439475 the link render:

image

Send to: https://www.amazon.uk/dp/0141439475
Correct need include .co: https://www.amazon.co.uk/dp/0141439475
OzzieIsaacs added a commit that referenced this issue Sep 21, 2024
@OzzieIsaacs
Fix for #3151 (Invalid amazon link for uk)
2f39e51
@OzzieIsaacs
Copy link
Collaborator

no rule without exception...

Please install a new package neamed "netifaces-plus" (has nothing to do with this fix) and update to the newest nightly version to enjoy the fix

@OzzieIsaacs OzzieIsaacs reopened this Sep 22, 2024
@OzzieIsaacs
Copy link
Collaborator

Please leave it open till the next release

@webysther
Copy link
Contributor Author

webysther commented Sep 24, 2024 •
edited
Loading

Oh boy... This also happens with amazon of brazil, amazon_br:8535282513 solve to https://amazon.br/dp/8535282513 but is https://amazon.com.br/dp/8535282513

Maybe creating a dict of amazon around world or just using https://www.amazon.com/dp/ID?

For the amazon list: https://www.searchapi.io/docs/parameters/amazon/domain

@webysther webysther mentioned this issue Sep 24, 2024
Merged
@webysther webysther changed the title Invalid amazon link for uk Invalid amazon link Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixed in Nightly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update with all amazon site that diverge in domain style webysther/calibre-web
2 participants
@webysther @OzzieIsaacs