Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions when updating #37

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

bjfultn
Copy link

@bjfultn bjfultn commented Oct 4, 2019

@bjfultn bjfultn mentioned this pull request Oct 4, 2019
run Outdated
@@ -64,6 +64,7 @@ if [[ -z "$DBOX_SKIP_UPDATE" ]]; then
fi
fi

chmod -R a+rx /opt/dropbox/
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is overly broad, and will set the executable bit on many files that aren't executable. I used

chmod a+rx /opt/dropbox/dropbox-lnx*/*.so

Copy link
Author

@bjfultn bjfultn Oct 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Changed as suggested.

@tomp61
Copy link

tomp61 commented Oct 8, 2019

Please merge this patch!

@pixeldrew
Copy link

Please merge this

@jswetzen
Copy link

It’s strange, I can’t build the image. It fails at
gpg: requesting key 5044912E from hkp server pgp.mit.edu

@jswetzen
Copy link

Aha, I got it working by installing ca-certificates before the first RUN command. But it’s in there too, so I’m not sure why it won’t work. Possibly the apt-get comes after the gpg key fetching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants