Skip to content
This repository has been archived by the owner on Jun 9, 2022. It is now read-only.

Commit

Permalink
adds atomic boost library for cppnetlib
Browse files Browse the repository at this point in the history
  • Loading branch information
Steve Plaza committed May 20, 2014
1 parent c976e36 commit 069e908
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions boost.cmake
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ set (boost_LIBS ${BUILDEM_LIB_DIR}/libboost_thread.${BUILDEM_PLATFORM_DYLIB_EXTE
${BUILDEM_LIB_DIR}/libboost_python.${BUILDEM_PLATFORM_DYLIB_EXTENSION}
${BUILDEM_LIB_DIR}/libboost_unit_test_framework.${BUILDEM_PLATFORM_DYLIB_EXTENSION}
${BUILDEM_LIB_DIR}/libboost_filesystem.${BUILDEM_PLATFORM_DYLIB_EXTENSION}
${BUILDEM_LIB_DIR}/libboost_chrono.${BUILDEM_PLATFORM_DYLIB_EXTENSION} )
${BUILDEM_LIB_DIR}/libboost_chrono.${BUILDEM_PLATFORM_DYLIB_EXTENSION}
${BUILDEM_LIB_DIR}/libboost_atomic.${BUILDEM_PLATFORM_DYLIB_EXTENSION} )

# Add layout=tagged param to first boost install to explicitly create -mt libraries
# some libraries require. TODO: Possibly shore up all library find paths to only
Expand All @@ -42,7 +43,7 @@ ExternalProject_Add(${boost_NAME}
UPDATE_COMMAND ""
PATCH_COMMAND ""
CONFIGURE_COMMAND ${BUILDEM_ENV_STRING} ./bootstrap.sh
--with-libraries=date_time,filesystem,python,regex,serialization,system,test,thread,program_options,chrono
--with-libraries=date_time,filesystem,python,regex,serialization,system,test,thread,program_options,chrono,atomic
--with-python=${PYTHON_EXE}
--prefix=${BUILDEM_DIR}
LDFLAGS=${BUILDEM_LDFLAGS}
Expand Down

2 comments on commit 069e908

@chaubold
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This currently does not compile on OSX 10.9 Mavericks, with a bunch of those errors.
Is boost-atomic critical for any package?

./boost/atomic/detail/gcc-atomic.hpp:997:38: error: no viable conversion from 'int' to 'storage_type' (aka 'boost::atomics::detail::storage128_type')
        storage_type expected_s = 0, desired_s = 0;
                                     ^           ~
./boost/atomic/detail/gcc-atomic.hpp:932:28: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'int' to 'const boost::atomics::detail::storage128_type &' for 1st argument
struct BOOST_ALIGNMENT(16) storage128_type
                           ^

@chaubold
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, it was not atomic, but Apple's update to clang that caused the error. I'll add a patch for this, see Homebrew/legacy-homebrew#27396.

Please sign in to comment.