Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support stack_ fun #103

Draft
wants to merge 3 commits into
base: jane
Choose a base branch
from
Draft

Support stack_ fun #103

wants to merge 3 commits into from

Conversation

riaqn
Copy link

@riaqn riaqn commented Feb 14, 2025

This PR is to accomodate compiler parser changes in ocaml-flambda/flambda-backend#3106

@riaqn riaqn marked this pull request as draft February 14, 2025 17:31
@riaqn
Copy link
Author

riaqn commented Feb 14, 2025 •
edited
Loading

This is currently blocked by two issues:

  • -x is not simple_expr in parser, but parsed as Pexp_prefix and thus counts as Exp.is_simple_in_parser. This is fixed by the last commit.
  • STACK has too high priority - in particular, stack_ c#x should not parse as (stack_ c) # x. This needs to be fixed in the compiler parser first. Fix stack_ precedence ocaml-flambda/flambda-backend#3583

@riaqn riaqn mentioned this pull request Feb 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@riaqn