[needs review] Fix compilation on MacOS X 10.9

[avsm]

• Various type mismatches between signed/unsigned.
• Do not include tr1 on LLVM

Fixes #1, but I'm not at all sure that my fixes don't break the library in the cases of long string lengths. The existing code mixes up the types badly enough that the original author should look at this again rather than accept this particular patch I think.

[seanmcl]

I'm interested in this fix as well.

[ghost]

Part of this patch is against the code from google. Did you reported it upstream? I don't mind applying the patch until this is fixed properly though.

[yminsky]

There might be a good for re2 upstream. Cc'ng. Damon so he can look into
it.
On Nov 7, 2013 4:57 AM, "Jérémie Dimino" notifications@github.com wrote:

Part of this patch is against the code from google. Did you reported it
upstream? I don't mind applying the patch until this is fixed properly
though.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-27950058
.

[yminsky]

Sorry, could I have some context for this? A copy of this patch would be a
good start.

Wang

On Thu, Nov 7, 2013 at 6:19 AM, Yaron Minsky yminsky@gmail.com wrote:

There might be a good for re2 upstream. Cc'ng. Damon so he can look into
it.
On Nov 7, 2013 4:57 AM, "Jérémie Dimino" notifications@github.com wrote:

Part of this patch is against the code from google. Did you reported it
upstream? I don't mind applying the patch until this is fixed properly
though.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-27950058
.

[seanmcl]

avsm@d4841a2

On Thu, Nov 7, 2013 at 9:57 AM, Yaron Minsky notifications@github.comwrote:

Sorry, could I have some context for this? A copy of this patch would be a
good start.

Wang

On Thu, Nov 7, 2013 at 6:19 AM, Yaron Minsky yminsky@gmail.com wrote:

There might be a good for re2 upstream. Cc'ng. Damon so he can look into
it.
On Nov 7, 2013 4:57 AM, "Jérémie Dimino" notifications@github.com
wrote:

Part of this patch is against the code from google. Did you reported it
upstream? I don't mind applying the patch until this is fixed properly
though.

—
Reply to this email directly or view it on GitHub<
https://github.com/janestreet/re2/pull/2#issuecomment-27950058>
.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-27971994
.

[dch]

wonderful - thanks!

However it doesn't seem released to opam yet, is there a further step required to make this available to normal users?

opam install re2 still picks up

=-=-= Installing re2.109.45.00 =-=-=
default    Downloading https://opam.ocaml.org/archives/re2.109.45.00+opam.tar.gz
Downloading https://opam.ocaml.org/archives/re2.109.45.00+opam.tar.gz
Building re2.109.45.00:
  make
  make install
[ERROR] The compilation of re2.109.45.00 failed.
Removing re2.109.45.00.
  ocamlfind remove re2

[ghost]

No, just wait for the package to be accepted:

ocaml/opam-repository#1288

[dch]

FWIW works now, many thanks Jane Street & Anil for fixing this (just in the
nick of time for the book release ;-)

On 11 November 2013 12:49, Jérémie Dimino notifications@github.com wrote:

No, just wait for the package to be accepted:

ocaml/opam-repository#1288ocaml/opam-repository#1288

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-28192415
.

[avsm]

what a coincidence :-)

On 11 Nov 2013, at 12:24, Dave Cottlehuber notifications@github.com wrote:

FWIW works now, many thanks Jane Street & Anil for fixing this (just in the
nick of time for the book release ;-)

On 11 November 2013 12:49, Jérémie Dimino notifications@github.com wrote:

No, just wait for the package to be accepted:

ocaml/opam-repository#1288ocaml/opam-repository#1288

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-28192415
.

—
Reply to this email directly or view it on GitHub.