Fix janet_formatbv() type when handling %d %u int specifiers #1167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At https://github.com/janet-lang/janet/blob/master/src/core/pp.c#L849, janet_formatbv() pulls a long instead of an int when handling the %d specifier, potentially leading to wrong results:
output:
In the wild this shows like this:
error thrown:
The same goes for
%u
and friends.