New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vm_commit #1200

Merged

bakpakin merged 1 commit into janet-lang:master from sogaiu:use-vm_commit

Jun 23, 2023

Contributor

sogaiu commented Jun 22, 2023 •

edited

Loading

This PR contains a suggestion to use vm_commit(); in place of janet_stack_frame(stack)->pc = pc;.

The vm_commit(); construct is used elsewhere within the JOP_CALL handling in which this instance of janet_stack_frame(stack)->pc = pc; appears:

janet/src/core/vm.c

Line 975 in 3a4d56a

vm_commit();
janet/src/core/vm.c

Line 993 in 3a4d56a

vm_commit();
janet/src/core/vm.c

Line 1002 in 3a4d56a

vm_commit();

Perhaps it makes sense to use vm_commit(); on line 983 as well?

Though I can see that if one wanted to leave the JANET_FUNCTION-handling parts of JOP_CALL and JOP_TAILCALL easier to compare, perhaps not using vm_commit(); might be preferrable.


          Use vm_commit

78eed9b

Member

bakpakin commented Jun 23, 2023

LGTM

bakpakin merged commit c3f4dc0 into janet-lang:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet