Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move range to corelib #1236

Merged
merged 3 commits into from
Aug 5, 2023
Merged

Move range to corelib #1236

merged 3 commits into from
Aug 5, 2023

Conversation

primo-ppcg
Copy link
Contributor

Related issue: #1235

  • Moves range from boot.janet to corelib.c
  • Adds slightly better test coverage for 3 argument forms

pepe
pepe approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member

@pepe pepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sogaiu
Copy link
Contributor

sogaiu commented Aug 5, 2023

I tested the changes against some of my repositories and didn't detect any issues 👍

@bakpakin bakpakin merged commit 3df24c5 into janet-lang:master Aug 5, 2023
@primo-ppcg primo-ppcg deleted the range branch August 6, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepe pepe pepe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@primo-ppcg @sogaiu @pepe @bakpakin