Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix bin+sep to add-bin dest argument #1485

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

sogaiu
Copy link
Contributor

@sogaiu sogaiu commented Aug 15, 2024

This PR is an attempt to address #1484.

With this change, one should be able to use bundle/add-bin like this:

(bundle/add-bin manifest
               "git-some-janets.janet"
               # dest argument
               "git-some-janets")

instead of having to express the same intent like this:

(bundle/add-bin manifest
                "git-some-janets.janet"
                # dest argument
                "bin/git-some-janets")

That is, if the optional dest argument is specified to bundle/add-bin, it will have bin and an appropriate separator prefixed to it before being passed to install/add-file.

I tested the new version with spork and one of my own repositories and it seems to work.

Copy link
Member

@pepe pepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bakpakin bakpakin merged commit 2dcc0ad into janet-lang:master Aug 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants