Handle additional exception RangeError in timestamp converting #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imagine a Meta Info like GPS Date Time: 2024:02:24 15:50:140501265154082Z This resulted (with at least ruby 3.1.4) into "integer 140501265154082 too big to convert to `int'" /usr/local/rvm/rubies/ruby-3.1.4/lib/ruby/3.1.0/time.rb:264:in `utc' /usr/local/rvm/rubies/ruby-3.1.4/lib/ruby/3.1.0/time.rb:264:in `make_time' /usr/local/rvm/rubies/ruby-3.1.4/lib/ruby/3.1.0/time.rb:383:in `parse' /var/www/pictrs/shared/bundle/ruby/3.1.0/gems/mini_exiftool-2.10.4/lib/mini_exiftool.rb:454:in `convert_after_load'
Owner
|
It's fixed in mini_exiftool 2.11.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imagine a Meta Info like (real example from wildlife)
GPS Date Time: 2024:02:24 15:50:140501265154082Z
This resulted (with at least ruby 3.1.4) into
Perhaps the regex should actually catch this. But I think this is a pragmatic solution