generated from NiklasEi/bevy_game_template
-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable full-screen #254
Merged
Merged
Enable full-screen #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do you prefer Fullscreen or Borderless Window as a default? |
Borderless window please :) |
I realize this is still a draft, but just in case, FYI: you remove |
This reverts commit 9459a66.
@janhohenheim This should be ready to review now. |
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #252.
This PR enables full-screen for both native and web builds.
Unfortunately this makes the web page a bit less pretty until the game loads in.
I propose to fix that with a proper loading screen (in HTML/JS), I have a prototype for that here: ramirezmike/game_off_2022#1.
That's a topic for a future PR though.
I also added a (very primitive) exit button to the pause menu so that you don't get stuck in the game on native.