Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable full-screen #254

Merged
merged 10 commits into from
Apr 10, 2023
Merged

Conversation

TimJentzsch
Copy link
Collaborator

@TimJentzsch TimJentzsch commented Apr 9, 2023

Closes #252.

This PR enables full-screen for both native and web builds.

Unfortunately this makes the web page a bit less pretty until the game loads in.
I propose to fix that with a proper loading screen (in HTML/JS), I have a prototype for that here: ramirezmike/game_off_2022#1.
That's a topic for a future PR though.

I also added a (very primitive) exit button to the pause menu so that you don't get stuck in the game on native.

@TimJentzsch
Copy link
Collaborator Author

Do you prefer Fullscreen or Borderless Window as a default?

@janhohenheim
Copy link
Owner

Borderless window please :)

@janhohenheim
Copy link
Owner

I realize this is still a draft, but just in case, FYI: you remove --game-ui-height from the css, but the code still references it.

@TimJentzsch TimJentzsch marked this pull request as ready for review April 10, 2023 09:06
@TimJentzsch
Copy link
Collaborator Author

@janhohenheim This should be ready to review now.
The quit button is ugly and the quit on WASM a bit hacky, but it seems to work :)

@janhohenheim janhohenheim merged commit d7f0c17 into janhohenheim:main Apr 10, 2023
@janhohenheim
Copy link
Owner

LGTM!

@TimJentzsch TimJentzsch deleted the 252-fullscreen branch April 10, 2023 13:43
janhohenheim added a commit that referenced this pull request Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make game fullscreen
2 participants