Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epic: cortex engines commands #1072

Closed
17 tasks done
Tracked by #3614
vansangpfiev opened this issue Aug 22, 2024 · 7 comments
Closed
17 tasks done
Tracked by #3614

epic: cortex engines commands #1072

vansangpfiev opened this issue Aug 22, 2024 · 7 comments
Assignees
Labels
category: engine management Related to engine abstraction type: feature request A new feature

Comments

@vansangpfiev
Copy link
Contributor

vansangpfiev commented Aug 22, 2024

Goal

  • Cortex can install engines (e.g. llama.cpp, tensorrt-llm)
  • Strong error recovery

Spec

Tasklist

Install (this issue)

  • HTTP API support for cortex engines install
  • CLI support for cortex engines <name (cortex.llamacpp/cortex.tensorrt-llm/cortex.onnx)> install
  • Downloading and unzip engine file (currently store engine to engines/<engine>)
  • Downloading and unzip cuda toolkit (if needed - because, e.g. macos does not need this)
  • Libcurl adding libcurl to support pause/resume download #1179
  • Hardware detection
    • AVX information
    • OS
    • CPU arch
    • GPU driver version

Engines list

Engines get

Uninstall

Dependency Packing

Outstanding / Bugs:

Some resources

Nvidia Support Matrix
CUDA Compatibility

@namchuai
Copy link
Contributor

@vansangpfiev @nguyenhoangthuan99 , please add if I missing any. Thank you 🙏

@dan-homebrew
Copy link
Contributor

@namchuai Can I clarify a few things:

  • CLI command: is it install or init? If install, let's change this issue name
  • Will we do an uninstall command as well?

@dan-homebrew
Copy link
Contributor

dan-homebrew commented Aug 29, 2024

@namchuai Another thought is, should the command be:

cortex engines install tensorrt-llm
or 
cortex engines tensorrt-llm install

I had originally gone with cortex engines tensorrt-llm install, because I initially thought that each of the engines would eventually expose its own CLI commands, e.g:

cortex engines tensorrt-llm settings ...
cortex engines tensorrt-llm gpu 2

However, I realize that install is an action on engines, rather than tensorrt-llm (or engine name). In this case, the correct approach should be:

cortex engines install tensorrt-llm
cortex engines uninstall tensorrt-llm
cortex engines list

@namchuai namchuai changed the title cortex engines init CLI: cortex engines <engine> install Aug 30, 2024
@namchuai
Copy link
Contributor

@namchuai Can I clarify a few things:

  • CLI command: is it install or init? If install, let's change this issue name
  • Will we do an uninstall command as well?
  1. Yes, it's install. I updated the title.
  2. I agree about uninstall
    cc @vansangpfiev @nguyenhoangthuan99 , what do you think?

@namchuai
Copy link
Contributor

@namchuai Another thought is, should the command be:

cortex engines install tensorrt-llm
or 
cortex engines tensorrt-llm install

I had originally gone with cortex engines tensorrt-llm install, because I initially thought that each of the engines would eventually expose its own CLI commands, e.g:

cortex engines tensorrt-llm settings ...
cortex engines tensorrt-llm gpu 2

However, I realize that install is an action on engines, rather than tensorrt-llm (or engine name). In this case, the correct approach should be:

cortex engines install tensorrt-llm
cortex engines uninstall tensorrt-llm
cortex engines list

IMHO, 2nd option is more natural to me.

$ cortex engines install tensorrt-llm

And I think we should support options if any, for example:

$ cortex engines install cortex.llamacpp --vulkan 1

@vansangpfiev
Copy link
Contributor Author

@namchuai Can I clarify a few things:

  • CLI command: is it install or init? If install, let's change this issue name
  • Will we do an uninstall command as well?
  1. Yes, it's install. I updated the title.
  2. I agree about uninstall
    cc @vansangpfiev @nguyenhoangthuan99 , what do you think?

I agree, we should support uninstall. @namchuai Can you please create a ticket for it?

@imtuyethan imtuyethan transferred this issue from another repository Sep 2, 2024
@imtuyethan imtuyethan moved this to Planning in Jan & Cortex Sep 2, 2024
@imtuyethan imtuyethan added the type: feature request A new feature label Sep 2, 2024
@0xSage 0xSage changed the title CLI: cortex engines <engine> install CLI: cortex engines install <engine_id> Sep 6, 2024
@0xSage 0xSage changed the title CLI: cortex engines install <engine_id> feat(CLI): cortex engines install <engine_id> Sep 6, 2024
@dan-homebrew dan-homebrew added the category: engine management Related to engine abstraction label Sep 6, 2024
@dan-homebrew dan-homebrew changed the title feat(CLI): cortex engines install <engine_id> feat: cortex engines install <engine_id> Sep 8, 2024
@dan-homebrew dan-homebrew changed the title feat: cortex engines install <engine_id> feat: cortex engines install <engine_id> Sep 8, 2024
@dan-homebrew dan-homebrew changed the title feat: cortex engines install <engine_id> feat: cortex engines install <engine_id> and engine commands Sep 8, 2024
@dan-homebrew dan-homebrew moved this from In Review to Review + QA in Jan & Cortex Sep 29, 2024
@gabrielle-ong gabrielle-ong changed the title feat: cortex engines install <engine_id> and engine commands epic: cortex engines commands Oct 3, 2024
@gabrielle-ong
Copy link
Contributor

Closing this Epic 🌮 🎉 Thanks @vansangpfiev @namchuai!

@gabrielle-ong gabrielle-ong moved this from Review + QA to Completed in Jan & Cortex Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: engine management Related to engine abstraction type: feature request A new feature
Projects
Archived in project
Development

No branches or pull requests

5 participants