Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add some unit tests #1158

Merged
merged 1 commit into from
Sep 9, 2024
Merged

chore: add some unit tests #1158

merged 1 commit into from
Sep 9, 2024

Conversation

namchuai
Copy link
Contributor

@namchuai namchuai commented Sep 8, 2024

Describe Your Changes

  • Adding unit test for finding suitable hardware.
  • Fix mac build issue with unit test.

Screenshot

Screenshot 2024-09-09 at 11 01 29

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@dan-homebrew
Copy link
Contributor

dan-homebrew commented Sep 9, 2024

@namchuai: A few PM requests from me (once you finish your draft)

In the future, I would push for you guys to include unit tests with the issue-closing PR, so it's easier to refer to. But for now, I really appreciate the push to increase test coverage

@namchuai namchuai marked this pull request as ready for review September 9, 2024 04:03
Copy link
Contributor

@vansangpfiev vansangpfiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding unit tests

Copy link
Contributor

@dan-homebrew dan-homebrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - thanks for writing tests

@namchuai namchuai merged commit dd4562c into dev Sep 9, 2024
4 checks passed
@namchuai namchuai deleted the j/adding-unit-tests branch September 9, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants