Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(mac): cortexcpp folder installs with wrong permissions #1274

Closed
Tracked by #1154
0xSage opened this issue Sep 19, 2024 · 5 comments · Fixed by #1294
Closed
Tracked by #1154

bug(mac): cortexcpp folder installs with wrong permissions #1274

0xSage opened this issue Sep 19, 2024 · 5 comments · Fixed by #1294
Assignees
Labels
category: app shell Installer, updaters, distributions os: Mac P0: critical Mission critical type: bug Something isn't working
Milestone

Comments

@0xSage
Copy link
Contributor

0xSage commented Sep 19, 2024

OS: MacOS

To Repro

  1. Use macos installer
  2. View cortexcpp-nightly folder > Get Info
  3. Permissions are wrong:
image

It should be:
image
Where root user or admin has read & write

Problem

This causes many downstream issues:

❌ Users have to do sudo for all commands, really annoying
❌ All chained commands will fail
sudo cortex run ... still encounters permission denied issue
e.g.

> sudo cortex-nightly run mistral

Starting server ...
20240919 15:54:32.723277 UTC 33913 INFO  Host: 127.0.0.1 Port: 3928
 - main.cc:32

Error opening file: Permission denied

Server started

Error opening file: Permission denied

Model loaded!
Inorder to exit, type `exit()`

Questions

  • How to resolve this?
  • Is this happening on Windows/Linux? I haven't gotten a chance to verify
@0xSage 0xSage added P0: critical Mission critical category: app shell Installer, updaters, distributions labels Sep 19, 2024
@0xSage 0xSage moved this to Need Investigation in Jan & Cortex Sep 19, 2024
@0xSage 0xSage added this to the v0.1.0 milestone Sep 19, 2024
@0xSage 0xSage changed the title discussion: cortexcpp-nightly installs with wrong permissions bug: cortexcpp-nightly installs with wrong permissions Sep 19, 2024
@0xSage 0xSage added the type: bug Something isn't working label Sep 19, 2024
@0xSage 0xSage changed the title bug: cortexcpp-nightly installs with wrong permissions bug: cortexcpp folder installs with wrong permissions Sep 19, 2024
@0xSage 0xSage added the os: Mac label Sep 19, 2024
@hiento09
Copy link
Contributor

@vansangpfiev is working on this PR to fix the bug #1267

@0xSage
Copy link
Contributor Author

0xSage commented Sep 20, 2024 via email

@vansangpfiev
Copy link
Contributor

This should be fixed by cortex-nightly v0.5.0-72.
Can you please uninstall cortex-nightly, install v0.5.0-72 then try again?

@0xSage
Copy link
Contributor Author

0xSage commented Sep 21, 2024

se uninstall cortex-nightly, install v0.5.0-72 then try again?

Installed v75, still experiencing this issue:

image

image

What is the nature of the issue and the fix? Would like to understand a bit more, as we didn't have this issue previously (with javascript, using when using npm/brew/package managers).

For reference I dont have this issue with other apps that also download non-hidden folders onto ~/:

  • Postman Agent
  • Screen Studio
  • etc

@0xSage 0xSage changed the title bug: cortexcpp folder installs with wrong permissions bug(mac): cortexcpp folder installs with wrong permissions Sep 23, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Jan & Cortex Sep 23, 2024
@0xSage
Copy link
Contributor Author

0xSage commented Sep 23, 2024

Can verify this is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: app shell Installer, updaters, distributions os: Mac P0: critical Mission critical type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants