Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Windows Network Installer Progress Bar should account for downloading of dependencies #1355

Closed
1 of 6 tasks
Tracked by #1030
0xSage opened this issue Sep 30, 2024 · 9 comments
Closed
1 of 6 tasks
Tracked by #1030
Assignees
Labels
type: bug Something isn't working

Comments

@0xSage
Copy link
Contributor

0xSage commented Sep 30, 2024

Cortex version

v123

Describe the Bug

  1. Use latest windows installer
  2. Go through all the steps
  3. Final step / download status stalls at 100% for 2-5 minutes
  4. User isn't able to click close or exit

Only filing this issue because its a noticeable increase in the stall time since previous versions v8x.

Questions:

  1. What are we doing in this final step?
  2. Is it better to show this as "in progress" if the final step takes time.

Steps to Reproduce

No response

Screenshots / Logs

image

What is your OS?

  • MacOS
  • Windows
  • Linux

What engine are you running?

  • cortex.llamacpp (default)
  • cortex.tensorrt-llm (Nvidia GPUs)
  • cortex.onnx (NPUs, DirectML)
@0xSage 0xSage added the type: bug Something isn't working label Sep 30, 2024
@hiento09
Copy link
Contributor

hiento09 commented Oct 1, 2024

The installer process on Windows hangs when it’s downloading the llamacpp engine along with dependencies from the internet. I will update the Installer UI to avoid user confusion. The prolonged hang time might be due to the network speed of the end user.

@github-project-automation github-project-automation bot moved this to Investigating in Jan & Cortex Oct 1, 2024
@hiento09 hiento09 moved this from Investigating to Scheduled in Jan & Cortex Oct 1, 2024
@0xSage
Copy link
Contributor Author

0xSage commented Oct 1, 2024 via email

@hiento09
Copy link
Contributor

hiento09 commented Oct 1, 2024

New Approach @0xSage

Installer.mp4

@0xSage
Copy link
Contributor Author

0xSage commented Oct 1, 2024

@hiento09 Is it possible for us to do this without popping up a terminal window?

Popping up a terminal window, without the user's knowledge, feels like we're downloading a virus.

Is it possible to adjust the green progress bar, in the native windows installer, to account for the dependency download status? At the moment, the only confusing part is it says 100%, but the downloader is still downloading.

@hiento09
Copy link
Contributor

hiento09 commented Oct 1, 2024

@hiento09 Is it possible for us to do this without popping up a terminal window?

Popping up a terminal window, without the user's knowledge, feels like we're downloading a virus.

Is it possible to adjust the green progress bar, in the native windows installer, to account for the dependency download status? At the moment, the only confusing part is it says 100%, but the downloader is still downloading.

Ok, let me try searching for a way to display 80% or 90% instead of 100% as it currently shows.

@dan-homebrew dan-homebrew changed the title bug: Windows installer final screen stalls much longer bug: Windows Network Installer should account for downloading of dependencies Oct 2, 2024
@dan-homebrew dan-homebrew changed the title bug: Windows Network Installer should account for downloading of dependencies bug: Windows Network Installer Progress Bar should account for downloading of dependencies Oct 2, 2024
@hiento09
Copy link
Contributor

hiento09 commented Oct 2, 2024

installer.mp4

@gabrielle-ong
Copy link
Contributor

@hiento09 is there a way to increment the progress bar with download progress between 80% to 100%?

If it's too much effort, we can KIV - as we are focusing on the full installer

@hiento09
Copy link
Contributor

hiento09 commented Oct 4, 2024

@hiento09 is there a way to increment the progress bar with download progress between 80% to 100%?

If it's too much effort, we can KIV - as we are focusing on the full installer

Hi @gabrielle-ong , I haven't found a way to increment the progress bar between 80% to 100% based on download progress yet. Let's KIV this.

@gabrielle-ong gabrielle-ong moved this from Review + QA to Completed in Jan & Cortex Oct 4, 2024
@gabrielle-ong
Copy link
Contributor

Closing - thank you Hien!

@github-project-automation github-project-automation bot moved this from Completed to Review + QA in Jan & Cortex Oct 4, 2024
@gabrielle-ong gabrielle-ong moved this from Review + QA to Completed in Jan & Cortex Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants