Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epic: llamacpp-engine to align with llama.cpp upstream #1728

Open
dan-homebrew opened this issue Nov 26, 2024 · 1 comment
Open

epic: llamacpp-engine to align with llama.cpp upstream #1728

dan-homebrew opened this issue Nov 26, 2024 · 1 comment
Assignees
Labels
type: epic A major feature or initiative

Comments

@dan-homebrew
Copy link
Contributor

Goal

  • cortex.cpp's desktop focus means Drogon's features are unused
  • We should contribute our vision and multimodal work upstream as a form of llama.cpp server

Can we consider refactoring llamacpp-engine to use the server implementation, and maintain a fork with our improvements to speech, vision etc? This is especially if we do a C++ implementation of whisperVQ in the future.

@dan-homebrew dan-homebrew added the type: epic A major feature or initiative label Nov 26, 2024
@github-project-automation github-project-automation bot moved this to Investigating in Jan & Cortex Nov 26, 2024
@vansangpfiev
Copy link
Contributor

I agree that we should align with the llama.cpp upstream, but I have several concerns:

  • Drogon is part of cortex.cpp, we have already removed it from llama-cpp engine. If we remove Drogon from cortex.cpp, we need to find a replacement, which will be costly.
  • Repository Structure: Forking the server implementation will necessitate changes to our repository structure, since we currently use llama.cpp as a submodule.
  • Our current version differs significantly from the upstream version, which will require considerable time for refactoring.

@gabrielle-ong gabrielle-ong added this to the v1.0.5 milestone Nov 28, 2024
@gabrielle-ong gabrielle-ong removed this from the v1.0.5 milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: epic A major feature or initiative
Projects
Status: Investigating
Development

No branches or pull requests

3 participants