This repository was archived by the owner on Jul 4, 2025. It is now read-only.
fix: validate url before pull #1382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namchuai
requested review from
nguyenhoangthuan99 and
vansangpfiev
and removed request for
nguyenhoangthuan99
vansangpfiev
approved these changes
Oct 2, 2024
vansangpfiev
reviewed
Oct 2, 2024
| return DownloadModelFromCortexso(model_id); | ||
| } | ||
|
|
||
| if (url_obj.pathParams.size() < 5) { |
Contributor
Author
There was a problem hiding this comment.
Sorry, I missed this one. I will add comment in the following PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Fixes Issues
cortex pull invalid_urlcreates a model folder #1270Self Checklist