Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: engine management #1546

Merged
merged 16 commits into from
Nov 5, 2024
Merged

feat: engine management #1546

merged 16 commits into from
Nov 5, 2024

Conversation

namchuai
Copy link
Contributor

@namchuai namchuai commented Oct 24, 2024 •
edited
Loading

Describe Your Changes

  • Clean up, gonna removing nlohmann::json
  • Refactoring InferenceService, moving engine logic to EngineService

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai force-pushed the j/engine-management branch 3 times, most recently from 308068c to 3dba0ce Compare October 28, 2024 14:23
@namchuai namchuai marked this pull request as ready for review October 29, 2024 11:11
@namchuai namchuai force-pushed the j/engine-management branch 4 times, most recently from 2a4662c to d344f30 Compare October 30, 2024 09:38
@namchuai namchuai requested review from nguyenhoangthuan99 and a team October 31, 2024 01:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024 •
edited
Loading

Preview URL: https://2caa50b4.cortex-docs.pages.dev

@namchuai namchuai force-pushed the j/engine-management branch 2 times, most recently from 63cca4f to 76481c5 Compare October 31, 2024 16:10
@namchuai namchuai force-pushed the j/engine-management branch 2 times, most recently from 3eef24d to edfa86e Compare November 5, 2024 05:44
vansangpfiev
vansangpfiev reviewed Nov 5, 2024
View reviewed changes
engine/services/engine_service.cc
@@ -466,7 +464,7 @@ cpp::result<bool, std::string> EngineService::DownloadCuda(
}};

auto on_finished = [engine](const DownloadTask& finishedTask) {
auto engine_path = file_manager_utils::GetEnginesContainerPath() / engine;
auto engine_path = file_manager_utils::GetCudaToolkitPath(engine);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename to cuda_path?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will update in following pr.

@namchuai namchuai merged commit 3e04350 into dev Nov 5, 2024
5 checks passed
@namchuai namchuai deleted the j/engine-management branch November 5, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vansangpfiev vansangpfiev vansangpfiev approved these changes

@nguyenhoangthuan99 nguyenhoangthuan99 Awaiting requested review from nguyenhoangthuan99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

epic: Improve Cortex Engine Management
2 participants
@namchuai @vansangpfiev