Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use download event type to listen ws on client side #1601

Merged
merged 3 commits into from
Nov 1, 2024
Merged

fix: use download event type to listen ws on client side #1601

merged 3 commits into from
Nov 1, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Nov 1, 2024 •
edited
Loading

Describe Your Changes

  • We are using id to listen to ws event, it is fragile so should use download event type instead

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review November 1, 2024 02:04
@vansangpfiev vansangpfiev requested a review from a team November 1, 2024 02:04
namchuai
namchuai approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ lgtm

@vansangpfiev vansangpfiev merged commit 166cdb5 into dev Nov 1, 2024
8 checks passed
@vansangpfiev vansangpfiev deleted the fix/use-event-type-to-listen-ws branch November 1, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vansangpfiev @namchuai @sangjanai