Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make cortex-nightly update -v works again #1645

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix: make cortex-nightly update -v works again #1645

merged 1 commit into from
Nov 6, 2024

Conversation

vansangpfiev
Copy link
Contributor

Describe Your Changes

  • Need to remove v in binary name

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev requested review from hiento09 and a team November 6, 2024 09:49
@vansangpfiev vansangpfiev marked this pull request as ready for review November 6, 2024 09:52
hiento09
hiento09 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@hiento09 hiento09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiento09 hiento09 merged commit 90bcb79 into dev Nov 6, 2024
7 of 8 checks passed
@hiento09 hiento09 deleted the fix/correct-nightly-update branch November 6, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiento09 hiento09 hiento09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vansangpfiev @hiento09