Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Jan into an Electron app #175

Merged
merged 51 commits into from
Sep 25, 2023

Conversation

louis-menlo
Copy link
Contributor

@louis-menlo louis-menlo commented Sep 14, 2023

Challenges

Achieved

  • Add electron build
  • Correct static export asset paths
  • Export static site for production bundle
  • Plugin Manager
Screenshot 2023-09-14 at 20 12 12 Screenshot 2023-09-19 at 14 28 20
demo.mov

Next Action Items:

  • Keep only Jan Desktop scaffold (auth & be dependencies should be decoupled and converted into plugins)
  • ...

Results

Screenshot 2023-09-14 at 16 31 22 Screenshot 2023-09-14 at 16 31 41

@jansonarqube

This comment has been minimized.

@jansonarqube

This comment has been minimized.

@jansonarqube

This comment has been minimized.

@jansonarqube

This comment has been minimized.

@jansonarqube

This comment has been minimized.

@jansonarqube

This comment has been minimized.

@louis-menlo louis-menlo force-pushed the feature/hackathon-refactor-jan-into-electron-app branch from 0946a16 to 3476f1d Compare September 18, 2023 08:46
@jansonarqube

This comment has been minimized.

1 similar comment
@jansonarqube

This comment has been minimized.

@jansonarqube

This comment has been minimized.

@freelerobot freelerobot added P0: critical Mission critical type: epic A major feature or initiative labels Sep 19, 2023
@jansonarqube

This comment has been minimized.

@louis-menlo louis-menlo force-pushed the feature/hackathon-refactor-jan-into-electron-app branch from 860a711 to a990012 Compare September 19, 2023 07:48
@jansonarqube

This comment has been minimized.

1 similar comment
@jansonarqube

This comment has been minimized.

@louis-menlo louis-menlo force-pushed the feature/hackathon-refactor-jan-into-electron-app branch from a990012 to c21634c Compare September 19, 2023 07:54
@louis-menlo louis-menlo force-pushed the feature/hackathon-refactor-jan-into-electron-app branch from c21634c to 7a25f94 Compare September 19, 2023 07:54
@jansonarqube

This comment has been minimized.

1 similar comment
@jansonarqube

This comment has been minimized.

@jansonarqube

This comment has been minimized.

@hiento09 hiento09 force-pushed the feature/hackathon-refactor-jan-into-electron-app branch from f00be6f to 0dec38c Compare September 21, 2023 11:24
@jansonarqube

This comment has been minimized.

Signed-off-by: James <james@jan.ai>
@jansonarqube

This comment has been minimized.

@jansonarqube

This comment has been minimized.

Signed-off-by: James <james@jan.ai>
@jansonarqube

This comment has been minimized.

1 similar comment
@jansonarqube

This comment has been minimized.

@louis-menlo louis-menlo force-pushed the feature/hackathon-refactor-jan-into-electron-app branch from a11d2f0 to a47a766 Compare September 22, 2023 07:40
@jansonarqube

This comment has been minimized.

@jansonarqube

This comment has been minimized.

@jansonarqube

This comment has been minimized.

@jansonarqube

This comment has been minimized.

@jansonarqube

This comment has been minimized.

Signed-off-by: James <james@jan.ai>
@jansonarqube
Copy link

jansonarqube bot commented Sep 24, 2023

Failed

  • 0.00% Security Hotspots Reviewed on New Code (is less than 100.00%)

Analysis Details

115 Issues

  • Bug 25 Bugs
  • Vulnerability 5 Vulnerabilities
  • Code Smell 85 Code Smells

Coverage and Duplications

  • Coverage 0.00% Coverage (0.00% Estimated after merge)
  • Duplications 1.91% Duplicated Code (1.80% Estimated after merge)

Project ID: janhq_jan_AYpD9dALNKTWc87tHFux

View in SonarQube

@louis-menlo louis-menlo changed the title Draft: Refactor Jan into an Electron app Refactor Jan into an Electron app Sep 25, 2023
@louis-menlo louis-menlo marked this pull request as ready for review September 25, 2023 03:37
@namchuai
Copy link
Collaborator

such a big PR

@namchuai namchuai merged commit 20dbc02 into main Sep 25, 2023
@namchuai namchuai deleted the feature/hackathon-refactor-jan-into-electron-app branch September 25, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0: critical Mission critical type: epic A major feature or initiative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants