Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow users to add remote models #4534

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

louis-menlo
Copy link
Contributor

Describe Your Changes

Allow users to manually add models when model list URL is unavailable/inaccessible (e.g. OpenRouter).

AC:

  • User can manually add models for any remote
  • Added models appear in the model list in respective remote engine settings
  • Models can be configured and used normally
  • Proper error handling if:
    • model ID already exists

User can add new remote model

CleanShot 2025-01-28 at 16 56 01

Error handling - model already exists

CleanShot 2025-01-28 at 16 56 56

Out of scope:

  • model ID doesn't exists (/models settings don't work for all endpoints - KIV)

Fixes Issues

Changes

This pull request includes several changes to improve the management and addition of remote engine models. The key changes involve adding new functionalities for handling remote engine models, updating the UI components, and importing necessary modules.

Improvements to remote engine model management:

UI updates and new components:

Module imports:

@louis-menlo louis-menlo added type: ci CI, CD, and automations and removed type: ci CI, CD, and automations labels Jan 28, 2025
Copy link
Contributor

Barecheck - Code coverage report

Total: 67.88%

Your code coverage diff: -0.11% ▾

Uncovered files and lines
FileLines
core/src/browser/extensions/enginesManagement.ts19
web/hooks/useEngineManagement.ts35-36, 38, 59, 72-73, 75, 85, 87, 94, 101-102, 104, 114, 116, 123, 132, 137, 139, 145, 147, 149-152, 156-157, 160-161, 164, 175, 188, 192, 194, 200, 202-204, 206, 210-211, 214-215, 218, 227, 238-239, 241, 249, 252-253, 261, 265, 277, 279-280, 283, 285-286, 288-289, 302, 304-305, 308, 310-312, 314-315, 327, 329-330, 333, 335-337, 339-340, 349, 351-352, 355, 357-359, 361-362, 374, 376-377, 380, 382-384, 386-387, 398, 400-401, 404, 406, 411-412, 414-415

@louis-menlo louis-menlo merged commit 6dd090a into dev Jan 28, 2025
10 checks passed
@louis-menlo louis-menlo deleted the fix/allow-users-to-add-remote-models branch January 28, 2025 11:08
@github-actions github-actions bot added this to the v0.5.15 milestone Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roadmap: Allow Users To Add Remote Models
2 participants