Skip to content

Conversation

@TensorNull
Copy link

@TensorNull TensorNull commented Sep 23, 2025

Describe Your Changes

  • Added CometAPI to the remote model providers checklist.
  • Updated _meta.json to include CometAPI documentation link.
  • Modified yarn.lock to reflect changes in dependencies.
  • Implemented CometAPI provider in providers.ts with model configurations.
  • Enhanced utility functions to support CometAPI logo and title retrieval.
  • Created comprehensive documentation for CometAPI integration in cometapi.mdx.
  • Added CometAPI SVG logo to the public images directory.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (features)
  • Created issues for follow-up changes or refactoring needed

Screenshot

image image

Important

Add CometAPI integration with model configurations, update documentation, and modify utility functions for support.

  • Integration:
    • Added CometAPI to providers.ts with model configurations and API settings.
    • Enhanced utils.ts to support CometAPI logo and title retrieval.
  • Documentation:
    • Created cometapi.mdx for comprehensive CometAPI integration guide.
    • Updated _meta.json to include CometAPI documentation link.
  • Checklists:
    • Added CometAPI to autoqa/checklist.md and tests/checklist.md under Remote Model Providers.
  • Misc:
    • Modified yarn.lock to reflect changes in dependencies.

This description was created by Ellipsis for 3d5142a. You can customize this summary. It will automatically update as commits are pushed.

Copilot AI review requested due to automatic review settings September 23, 2025 15:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds CometAPI as a new remote model provider to the application, enabling access to 500+ AI models through a unified API. The integration follows the established patterns for other model providers.

Key changes:

  • Added CometAPI provider configuration with 20+ predefined models including GPT, Claude, Gemini, Grok, DeepSeek, and Qwen series
  • Created comprehensive documentation with setup instructions and troubleshooting guide
  • Updated utility functions to support CometAPI logo and title display

Reviewed Changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
web-app/src/lib/utils.ts Added CometAPI provider logo/title support and fixed string quote consistency
web-app/src/consts/providers.ts Added complete CometAPI provider configuration with 20+ model definitions
tests/checklist.md Added CometAPI to remote model providers testing checklist
docs/src/pages/docs/remote-models/cometapi.mdx Created comprehensive CometAPI integration documentation
docs/src/pages/docs/remote-models/_meta.json Added CometAPI navigation entry to documentation
autoqa/checklist.md Added CometAPI to automated QA testing checklist

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 3d5142a in 2 minutes and 53 seconds. Click for details.
  • Reviewed 415 lines of code in 6 files
  • Skipped 2 files when reviewing.
  • Skipped posting 8 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. autoqa/checklist.md:102
  • Draft comment:
    CometAPI checkbox added to the Remote Model Providers list. Verify it appears correctly in the UI.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. docs/src/pages/docs/remote-models/_meta.json:30
  • Draft comment:
    CometAPI entry in _meta.json is correct with proper title and href.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
3. docs/src/pages/docs/remote-models/cometapi.mdx:1
  • Draft comment:
    The new CometAPI documentation is comprehensive. Verify the relative image path ('../_assets/cometapi.png') resolves correctly in the deployed docs.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
4. tests/checklist.md:108
  • Draft comment:
    CometAPI checklist item added in tests is consistent with the provider updates.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
5. web-app/src/consts/providers.ts:345
  • Draft comment:
    The CometAPI provider configuration is implemented correctly; however, review the models list for consistency with the documentation. For example, the GPT series in docs includes 'chatgpt-4o-latest' which is missing here, the Grok series names differ ('grok-4-0709' expected vs 'grok-4' provided), and some DeepSeek models (e.g., 'deepseek-v3' and 'deepseek-r1-0528') mentioned in the docs are omitted.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50% The comment is speculative since it references documentation we don't have access to. It's asking for verification rather than pointing out a definite issue. The comment also uses language like "review" and compares against models that "are mentioned in the docs" without providing concrete evidence that these models should definitely be included. The models listed could be intentionally different from the documentation - maybe they represent a newer or different set of supported models. Without access to the official CometAPI documentation, we can't verify if this is actually an issue. Even if the documentation exists, asking for verification or review without concrete evidence of an issue violates our rules about speculative comments and asking authors to verify things. The comment should be deleted as it's speculative, asks for verification, and doesn't provide strong evidence that there's actually an issue to fix.
6. web-app/src/lib/utils.ts:31
  • Draft comment:
    Addition of CometAPI in getProviderLogo and getProviderTitle looks correct and consistent.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
7. autoqa/checklist.md:108
  • Draft comment:
    There seems to be a typographical error in "Modesl". It should probably be "Models".
  • Reason this comment was not posted:
    Comment was on unchanged code.
8. tests/checklist.md:115
  • Draft comment:
    Typographical: The sentence 'Ensure that a deleted model also not selectable or appear in old threads that used it.' is grammatically off. Consider rephrasing it (e.g., 'Ensure that a deleted model is not selectable and does not appear in old threads that used it.')
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_N8CDWPZj6chfnFXL

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

TensorNull and others added 2 commits September 23, 2025 23:28
- Added CometAPI to the remote model providers checklist.
- Updated _meta.json to include CometAPI documentation link.
- Modified yarn.lock to reflect changes in dependencies.
- Implemented CometAPI provider in providers.ts with model configurations.
- Enhanced utility functions to support CometAPI logo and title retrieval.
- Created comprehensive documentation for CometAPI integration in cometapi.mdx.
- Added CometAPI SVG logo to the public images directory.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 29, 2025 11:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 8 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Minh141120 Minh141120 self-requested a review October 1, 2025 12:44
Copilot AI review requested due to automatic review settings October 7, 2025 03:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 8 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@TensorNull
Copy link
Author

@Minh141120
Is there anything else I need to change?

@Minh141120
Copy link
Member

HI @TensorNull,

Really appreciate the time and effort you’ve put into this PR, thank you for taking the initiative. I just wanted to clarify that integrations with cloud model providers are generally coordinated through our business development (BD) process, rather than being added directly through open PRs

Sorry for any confusion here and thanks again for your work on this and for your understanding!

@TensorNull
Copy link
Author

@Minh141120
Okay, we sincerely believe that Jan is an outstanding project. We are very eager to connect with your business development team to explore more detailed aspects of potential cooperation. If you are interested, I can have my colleagues from the business team get in touch with you.

@Minh141120
Copy link
Member

@TensorNull,

Really appreciate your kind words, I’ve cc’d @eckartal , who handles our business development partnerships, to continue the conversation with you and your team regarding the cooperation details.

Looking forward to the discussion

@eckartal
Copy link
Collaborator

eckartal commented Oct 8, 2025

@Minh141120 Okay, we sincerely believe that Jan is an outstanding project. We are very eager to connect with your business development team to explore more detailed aspects of potential cooperation. If you are interested, I can have my colleagues from the business team get in touch with you.

Hey @TensorNull, it'd be awesome. Please ping me on Slack at emre@menlo.ai.

@longchen421
Copy link

longchen421 commented Oct 9, 2025

@Minh141120 Okay, we sincerely believe that Jan is an outstanding project. We are very eager to connect with your business development team to explore more detailed aspects of potential cooperation. If you are interested, I can have my colleagues from the business team get in touch with you.

Hey @TensorNull, it'd be awesome. Please ping me on Slack at emre@menlo.ai.

@eckartal Thanks ,well noted. I've sent Emre an invitation on Slack(This is Chen, Commercial Director from CometAPI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

idea: Add CometAPI Provider Support

4 participants