Skip to content

Commit

Permalink
use chai for improved string diffing
Browse files Browse the repository at this point in the history
  • Loading branch information
dasilvacontin committed May 29, 2015
1 parent abd32f0 commit 954a8fb
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
"test-browser-local": "npm run pre-test-browser && zuul --local 8080 -- test/context-test.js test/scanner-test.js test/parse-test.js test/render-test-browser.js"
},
"devDependencies": {
"chai": "^2.3.0",
"eslint": "^0.20.0",
"mocha": "^2.1.0",
"zuul": "^2.1.1"
Expand Down
4 changes: 3 additions & 1 deletion test/helper.js
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
assert = require('assert');
var chai = require('chai');
assert = chai.assert;
chai.should();
Mustache = require('../mustache');
2 changes: 1 addition & 1 deletion test/render-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ describe('Mustache.render', function () {
output = Mustache.render(test.template, view);
}

assert.equal(output, test.expect);
output.should.equal(test.expect);

This comment has been minimized.

Copy link
@phillipj

phillipj May 31, 2015

Collaborator
- failed: <internet explorer 8 on Windows 2003> (0 failed, 0 passed)

Not happy about Travis reporting it as a green build though :( Should we even test IE8?

I havent digged into the issue more than reading this chai discussion which says IE8 testing should be possible.

This comment has been minimized.

Copy link
@dasilvacontin

dasilvacontin Jun 11, 2015

Author Collaborator

Dang. Not much usage coming from IE6/7/8, but it would be a nice to have. http://www.sitepoint.com/browser-trends-june-2015-battle-second-place/

});

});
Expand Down

0 comments on commit 954a8fb

Please sign in to comment.