Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install release tools with npm rather than via pre-commit hook #666

Merged
merged 1 commit into from
Aug 2, 2018

Commits on Jul 28, 2018

  1. chore: install release tools with npm rather than via pre-commit hook

    Previously mocha, uglifyjs and jshint used when publishing a new version
    were ensured / installed by `Rakefile` via the pre-commit git hook.
    Those modules were automatically installed globally if not present in
    `$PATH`.
    
    Installing modules globally has one particular dowsides that we should
    avoid: we can't ensure developers publishing new mustache.js versions
    have the same version of these 3rd party modules installed.
    
    If instead we make these modules local dev dependencies, we can ensure
    which versions are installed, and we make 3rd party depedencies explicit
    by listing them in `package.json`, rather than in `Rakefile`.
    phillipj committed Jul 28, 2018
    Configuration menu
    Copy the full SHA
    77a516c View commit details
    Browse the repository at this point in the history