fix: prototype pollution #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for curiousity’s sake, I checked if this has any
significant performance impact and it does not.
Based on 10 runs before and after, all values in
percent:
MED AVG
get first level property 0.37 0.42
get second level property 0.40 0.61
get third level property 0.26 0.41
set first level property 2.25 2.16
set second level property 1.45 1.67
set third level property 2.05 1.98
push property into array -0.41 -0.51
2.25% slowdown as a worst case is not significant.
fix: update devdeps fix: drop node 6 from test matrix, we are still copmpatbile tho, this is for standard chore: ditch standard, so we can support older node versions in testing chore: use older npm version so we can support older nodes chore: master branch builds only chore: prefer npm install to npm ci nodejs/node#29841 chore: newer npm after all chore: no node 6 then grmpf chore: re-add standard
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For curiousity’s sake, I checked if this has any
significant performance impact and it does not.
Based on 10 runs before and after, all values in
percent:
2.25% slowdown as a worst case is not significant.