Add minSelect prop #166
Merged
Add minSelect prop #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
@janosh I'm not sure why the tests are failing, but they were successful earlier... and are always failing locally. Something's fishy Any ideas? |
Error: Cannot find module '/home/runner/work/svelte-multiselect/svelte-multiselect/src/options' imported from /home/runner/work/svelte-multiselect/svelte-multiselect/tests/multiselect.test.ts pre-commit.ci: - hook id: codespell - exit code: 65 src/options.ts:61: FO ==> OF, FOR, TO, DO, GO src/options.ts:61: RO ==> TO, ROW, ROB, ROD, ROE, ROT
janosh
reviewed
Nov 17, 2022
As described here: janosh#163 (comment)
for more information, see https://pre-commit.ci
|
@janosh I changed the name and functionality according to your recommendations :) PS: Today is the last day of our Scrum sprint, so hopefully we can get this merged within the day :D |
janosh
approved these changes
Nov 18, 2022
|
Thanks, great work! 👍 Will be released as v8.1.0 in a few mins. |
|
Thanks for the help with the PR, and the quick release! Cheers 🥂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163
Wasn't able to make tests because of #164