Replace li.scrollIntoViewIfNeeded() with li.scrollIntoView()
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew() (#87) and fix scrolling into view being flaky when wrapping around start/end of dropdown list with ugly setTimeout hack
custom option was always created as object
…nsert and append mode prev: both food, now: food and languages
waiting for selector "div.multiselect > ul.options" to be visible
selector resolved to hidden <ul class="options baz s-A85w8bJ9QKLL hidden">…</ul>
============================================================
❯tests/multiselect.test.ts:125:13
123|
124| await page.click(`input[id='foods']`)
125| await page.waitForSelector(`div.multiselect > ul.options`, {
| ^
126| state: `visible`,
127| })
waiting for selector "div.multiselect > ul.options > li"
selector resolved to 33 elements. Proceeding with the first one.
selector resolved to hidden <li aria-selected="false" class="s-A85w8bJ9QKLL">🍇 Grapes </li>
attempting click action
waiting for element to be visible, enabled and stable
element is not visible - waiting...
============================================================
❯tests/multiselect.test.ts:93:13
91|
92| await page.click(`div.multiselect`) // open the dropdown
93| await page.click(`div.multiselect > ul.options > li`) // select 1st …
| ^
…0ms exceeded.
waiting for element to be visible
element is not visible - waiting...
============================================================
❯tests/multiselect.test.ts:128:20
126| await page.click(`input#foods`)
127| const ul_options = await page.$(`div.multiselect > ul.options`)
128| await ul_options?.waitForElementState(`visible`)
| ^
129|
130| await page.hover(`text=🍌 Banana`) // hover any option to give it act…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #87.
scrollIntoViewIfNeededwas never standardized. While it has pretty good browser support (currently at 92%), it doesn't exist in Firefox leading to the error in #87.Also fixes a scrolling into view sometimes not working when wrapping around start/end of dropdown list using a setTimeout hack.