Change "Converted Trials" to the number of trials converted within the configured trial duration #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e trial conversion rate to all trials converted within the configured trial length. Previously, every month had its own tracker which was slow and had high memory usage. This also fixes a bug when a customer had more than one trial in a date range (e.g. two trials within a year). Previously, on the conversion of the later trial was checked and a conversion of the earlier trials were not recorded. With this fix, trials may be slightly higher now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a trial conversion was only recorded if the sale happened within the same month, which is very misleading and unreliable.