fix: remove unused contentHash

jantimon · Dec 28, 2019 · b48697f · b48697f
1 parent 7aad73d
commit b48697f
Show file tree

Hide file tree

Showing 7 changed files with 41 additions and 2 deletions.
diff --git a/src/index.js b/src/index.js
@@ -114,8 +114,7 @@ module.exports = class FaviconsWebpackPlugin {
  }
  const hash = crypto.createHash('sha256').update(content.toString('utf8')).digest('hex');
  const outputPath = getAssetPath(compilation, this.options.prefix, {hash, chunk: {
- hash: hash,
- contentHash: hash
+ hash: hash
  }});
  const logoOutputPath = outputPath + (outputPath.substr(-1) === '/' ? '' : '/') + 'favicon' + faviconExt; 
  compilation.assets[logoOutputPath] = {

diff --git a/test/prefixed.test.js b/test/prefixed.test.js
@@ -24,4 +24,20 @@ test('should allow configuring the output prefix', async t => {
  snapshotCompilationAssets(t, compilationStats);
 });
 
+test('should allow configuring the output prefix for light mode', async t => {
+ const dist = path.join(t.context.root, 'dist');
+ const compilationStats = await generate({
+ context: t.context.root,
+ output: {
+ path: dist,
+ },
+ plugins: [
+ new HtmlWebpackPlugin(),
+ new FaviconsWebpackPlugin({ logo, prefix: 'custom/prefix/[hash:8]', mode: 'light' }),
+ ],
+ });
+
+ snapshotCompilationAssets(t, compilationStats);
+})
+
 test.afterEach(t => fs.remove(t.context.root));
diff --git a/test/snapshots/html.false.test.js.snap b/test/snapshots/html.false.test.js.snap
diff --git a/test/snapshots/html.true.test.js.snap b/test/snapshots/html.true.test.js.snap
diff --git a/test/snapshots/light.test.js.snap b/test/snapshots/light.test.js.snap
diff --git a/test/snapshots/prefixed.test.js.md b/test/snapshots/prefixed.test.js.md
@@ -333,3 +333,27 @@ Generated by [AVA](https://ava.li).
   `,
   },
  ]
+
+## should allow configuring the output prefix for light mode
+
+> Snapshot 1
+
+ [
+  'custom/prefix/7efef726/favicon.png',
+  'index.html',
+  'main.js',
+ ]
+
+> Snapshot 2
+
+ [
+  {
+  assetName: 'custom/prefix/7efef726/favicon.png',
+  content: 'binary',
+  },
+  {
+  assetName: 'index.html',
+  content: `<!doctype html><html><head><link rel="icon" href="/custom/prefix/7efef726/favicon.png"></head><body></body></html>␊
+  `,
+  },
+ ]
diff --git a/test/snapshots/prefixed.test.js.snap b/test/snapshots/prefixed.test.js.snap