Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child compilation must use a separate cache object #179

Merged
merged 1 commit into from
Jan 19, 2016

Conversation

sokra
Copy link
Contributor

@sokra sokra commented Jan 18, 2016

fix for webpack/webpack#1890

yes, I know, this should be done automatically by webpack when creating a child compilation...
I'll add it in the next major version...

Sharing the cache cause bad issues with wrong module ids.
@jantimon
Copy link
Owner

I saw this in extract-text-plugin however there was no comment (like in this merge request) which explains what this code does and why

jantimon added a commit that referenced this pull request Jan 19, 2016
Child compilation must use a separate cache object
@jantimon jantimon merged commit f74928b into jantimon:feature/loaders Jan 19, 2016
This was referenced Jan 19, 2016
jantimon added a commit that referenced this pull request Jan 19, 2016
@jantimon
Copy link
Owner

Thanks a lot @sokra this fixed different issues including incomplete cache modules causing "HtmlWebpackPlugin Error: No source available"

@joetidee
Copy link

joetidee commented Sep 3, 2017

How is it possible to view which version of the html-webpack-plugin this fix was committed to (in order to set the correct version in my package.json) ?

@aimettii
Copy link

aimettii commented Sep 4, 2017

Update html-webpack-plugin did not help me. I use Laravel-mix, for hot replacement https://github.com/JeffreyWay/laravel-mix/blob/master/docs/hot-module-replacement.md

@digitaltopo
Copy link

Page does not reload when I make a change to a template or a partial (handlebars), using custom templates in html-webpack-plugin.

@lock
Copy link

lock bot commented May 31, 2018

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants