Failing builds on master after release

[jantman]

Still need to look into this: https://travis-ci.org/jantman/awslimitchecker/builds/97348751

[jantman]

Problem seems to be in the install_git tests, getting AssertionError: git clone not equal to origin.

Example from one of the tests:

• assertion - https://github.com/jantman/awslimitchecker/blob/master/awslimitchecker/tests/test_versioncheck.py#L1629
• failure output - https://travis-ci.org/jantman/awslimitchecker/jobs/97348759#L1458
• problem (verbose output): https://travis-ci.org/jantman/awslimitchecker/jobs/97348759#L1187

I think the problem might be in parsing the git status -u output when we're on a tag.

[jantman]

The problem is here: https://github.com/jantman/awslimitchecker/blob/master/awslimitchecker/tests/test_versioncheck.py#L1477

        if ('Your branch is up-to-date with' not in status and
                'HEAD detached at' not in status):
            print("\ngit status -u:\n" + status + "\n")
            return 1

The build job checked out a commit that pointed to a tag, but I'd already deleted the branch when I merged the PR, so the build ran against something that was a detached head.

We can clearly see the problem when looking at the output of Test_AGPLVersionChecker_Acceptance._check_git_pushed:

git status -u:
# Not currently on any branch.
nothing to commit, working directory clean

FAILED

I believe this should be fixed with 3e0b90f - I made that commit on an issues/112 branch, then tagged the commit "issue112" and pushed only the tag to origin, not the branch. That should be good to replicate this issue.

[jantman]

That build/commit fixed the issue here, but revealed a bug in versioncheck._is_git_dirty, also relating to not being on a branch - see https://travis-ci.org/jantman/awslimitchecker/jobs/97352774#L551

[DEBUG versioncheck.py:254 - awslimitchecker.versioncheck._is_git_dirty() ] Git repository dirty based on status: # Not currently on any branch.

nothing to commit, working directory clean

This looks like pretty much the same thing that I fixed in 3e0b90f

[jantman]

Merged into develop.