Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand integration tests #114

Closed
jantman opened this issue Jan 30, 2016 · 8 comments
Closed

Expand integration tests #114

jantman opened this issue Jan 30, 2016 · 8 comments

Comments

@jantman
Copy link
Owner

jantman commented Jan 30, 2016

Integration tests should also run for other regions, STS, threshold override, limit overrides and skip-ta.

@jantman jantman added this to the 0.3.0 milestone Jan 30, 2016
@jantman
Copy link
Owner Author

jantman commented Jan 30, 2016

Also, should save output, grep for warning or higher but not TA subscription.

Look into https://pypi.python.org/pypi/pytest-capturelog for this

@jantman
Copy link
Owner Author

jantman commented Feb 2, 2016

For STS, I can try two things: one, use a normal cross-account link, and two, try to use something like onetimepass or pyotp to auth with an MFA device.

jantman added a commit that referenced this issue Feb 11, 2016
jantman added a commit that referenced this issue Feb 11, 2016
jantman added a commit that referenced this issue Feb 11, 2016
…s setting Connectable.credentials to None before each Checker initialization
jantman added a commit that referenced this issue Feb 12, 2016
jantman added a commit that referenced this issue Feb 12, 2016
….ini, conftest.py's sanitize_line() was running the replacement on those characters
jantman added a commit that referenced this issue Feb 12, 2016
jantman added a commit that referenced this issue Feb 15, 2016
jantman added a commit that referenced this issue Feb 17, 2016
jantman added a commit that referenced this issue Feb 17, 2016
Issues/114 - expanded integration tests
@jantman
Copy link
Owner Author

jantman commented Feb 17, 2016

This was merged to develop in #124

@nagireddy451
Copy link

Hello jantman,

I need one help as per document i created the cross account detials in my script but i am not able to execute the script.

here is my script:

for i in range(1,count):
#pdb.set_trace()
response2=client.get_item(TableName='AWSlimitchecker', Key={'S.No':{'N':str(i)}})
pprint.pprint(str(response2['Item']['Region']['S']))
reg = str(response2['Item']['Region']['S'])
pprint.pprint(str(response2['Item']['Role']['S']))
iamrole = str(response2['Item']['Role']['S'])
pprint.pprint(str(response2['Item']['Accountnumber']['N']))
Account = str(response2['Item']['Accountnumber']['N'])
pprint.pprint(str(response2['Item']['Customer']['S']))
cust = str(response2['Item']['Customer']['S'])
#pdb.set_trace()
d = AwsLimitChecker(region=reg,account_id=Account,account_role=iamrole)
result = d.check_thresholds()
temp1=result.keys()
#pdb.set_trace()
if len(temp1)>0:
for m in temp1:
temp2=result[m].keys()
print 'first loop : '+m
#pdb.set_trace()
for n in temp2:
#pdb.set_trace()
try:
a = str(result[m][n].get_warnings()[0].get_value())
print 'The limit regarding the service "'+m+'" with limit name "'+n+'" the current limit value is : '+a
response3 = notif.publish(

@jantman
Copy link
Owner Author

jantman commented May 26, 2016

@nagireddy451

  1. Please open a new issue for this. This is unrelated to my "Expand integration tests" issue.
  2. It appears that your paste above is incomplete, and certainly doesn't include the output. When you open the new issue, please follow the guidelines in the new issue template, which can also be seen here.

@jantman
Copy link
Owner Author

jantman commented May 26, 2016

@nagireddy451 Looking at the above code, it seems that you're deploying awslimitchecker to monitor limits on customers' accounts? If so, I'll point you to the documentation section on Enterprise support agreements and contract development.

@nagireddy451
Copy link

Yes you are right but i dont need any paid support at the moment please
help how to configure for cross account execution.
For now i provide account id, account number, cross account arn but i not
able to execute the module as per document you wrote.

Thanks in advance.
On May 26, 2016 7:45 PM, "Jason Antman" notifications@github.com wrote:

@nagireddy451 https://github.com/nagireddy451 Looking at the above
code, it seems that you're deploying awslimitchecker to monitor limits on
customers' accounts? If so, I'll point you to the documentation section on Enterprise
support agreements and contract development
http://awslimitchecker.readthedocs.io/en/latest/getting_help.html#enterprise-support-agreements-and-contract-development
.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#114 (comment)

@jantman
Copy link
Owner Author

jantman commented May 27, 2016

PLEASE OPEN A NEW ISSUE. What you are asking is not related to this one.

When you open that issue, please complete ALL fields in the template.

Repository owner locked and limited conversation to collaborators May 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants