Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trusted Advisor On-Demand EC2 Usage #131

Closed
jantman opened this issue Feb 21, 2016 · 1 comment
Closed

Trusted Advisor On-Demand EC2 Usage #131

jantman opened this issue Feb 21, 2016 · 1 comment
Labels
enhancement
Milestone
0.3.1

Comments

@jantman
Copy link
Owner

jantman commented Feb 21, 2016

Per an announcement on Dec. 16, 2015 Trusted Advisor now returns information on on-demand EC2 instance limits:

[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - c1.medium' (service EC2)
[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - c3.2xlarge' (service EC2)
[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - c3.4xlarge' (service EC2)
[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - c3.large' (service EC2)
[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - c3.xlarge' (service EC2)
[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - c4.2xlarge' (service EC2)
[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - i2.2xlarge' (service EC2)
[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - m1.medium' (service EC2)
[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - m1.small' (service EC2)
[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - m3.2xlarge' (service EC2)
[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - m3.large' (service EC2)
[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - m3.medium' (service EC2)
[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - m3.xlarge' (service EC2)
[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - m4.4xlarge' (service EC2)
[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - m4.large' (service EC2)
[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - m4.xlarge' (service EC2)
[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - r3.2xlarge' (service EC2)
[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - r3.4xlarge' (service EC2)
[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - r3.large' (service EC2)
[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - t1.micro' (service EC2)
[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - t2.large' (service EC2)
[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - t2.medium' (service EC2)
[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - t2.micro' (service EC2)
[INFO trustedadvisor.py:231 - awslimitchecker.trustedadvisor._update_services() ] TrustedAdvisor returned check results for unknown limit 'On-Demand instances - t2.small' (service EC2)

Unfortunately, these are named differently from what ALC is using currently, so we'll need some sort of mapping for this - we've already got one special case for this, so we'll need to figure out a better way to handle that. Unfortunately this also crosses service boundaries, so perhaps Checker itself needs some sort of method to return the right limit for TA to update...
@jantman jantman added this to the 0.3.1 milestone Feb 21, 2016
jantman added a commit that referenced this issue Mar 3, 2016
@jantman
issue #131 rename a confusing variable
19ff1a6
jantman added a commit that referenced this issue Mar 3, 2016
@jantman
issue #131 - pass full Checker services dict into TrustedAdvisor, and…
e0dc416 
… flesh out docs for TA limit name munging
jantman added a commit that referenced this issue Mar 3, 2016
@jantman
issue #131 - AwsLimit ta_service_name and ta_limit_name
9a6e0bd
jantman added a commit that referenced this issue Mar 3, 2016
@jantman
issue #131 - refactor Trusted Advisor to AwsLimit logic to allow limi…
9df6254 
…ts to override the service and limit names their TA data uses
jantman added a commit that referenced this issue Mar 3, 2016
@jantman
Merge pull request #145 from /issues/131
bf411ad 
Issues/131
@jantman
Copy link
Owner Author

jantman commented Mar 3, 2016

fixed in #145 just merged to develop

@jantman jantman closed this as completed in aebb952 Mar 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.3.1
Development

No branches or pull requests
1 participant
@jantman