Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests fail for Pull Requests in Travis #46

Closed
jantman opened this issue Jul 25, 2015 · 1 comment
Closed

Integration tests fail for Pull Requests in Travis #46

jantman opened this issue Jul 25, 2015 · 1 comment
Labels
Milestone

Comments

@jantman
Copy link
Owner

jantman commented Jul 25, 2015

See e.g. https://travis-ci.org/jantman/awslimitchecker/jobs/72610593#L711

When Travis checks out a pull request, it checks out the merge of the PR to master, i.e. git fetch origin +refs/pull/45/merge. The git-based integration tests (Test_AGPLVersionChecker_Acceptance.test_install_git_e_dirty, Test_AGPLVersionChecker_Acceptance.test_install_git_e and Test_AGPLVersionChecker_Acceptance.test_install_git) attempt to install awslimitchecker from GitHub using the commit hash of the current git checkout that the tests exist in - which, in this case, is the merge hash, which doesn't exist yet in the repo.

Options that I can think of:
(1) don't just check out whatever hash the test repo is at, if it doesn't exist in origin.
(2) Look at the value of the TRAVIS_PULL_REQUEST environment variable, and do something different in the integration tests if we're testing a PR (such as installing +refs/pull/$TRAVIS_PULL_REQUEST/merge instead of the SHA).

@jantman jantman added this to the 0.1.1 milestone Jul 25, 2015
@jantman jantman mentioned this issue Jul 25, 2015
@jantman jantman added bug and removed enhancement labels Jul 26, 2015
jantman added a commit that referenced this issue Aug 11, 2015
… and disable on Travis; update development docs to run these manually.
@jantman jantman closed this as completed Aug 11, 2015
@jantman
Copy link
Owner Author

jantman commented Aug 13, 2015

This has been released in 0.1.1, which is now live on pypi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant