Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AWS EKS service, now it's available via Service Quota #472

Closed
quocdung3007 opened this issue Aug 4, 2020 · 4 comments
Closed

Comments

@quocdung3007
Copy link

Feature Description

I want to monitor all the limits for EKS via Service Quota which is recently supported by AWS https://aws.amazon.com/about-aws/whats-new/2020/08/amazon-eks-quotas-can-now-be-managed-through-aws-service-quotas/

Use Cases

This is will be useful for those using AWS EKS service to monitor their usage and raise the limit before it hits the limit.

Testing Assistance

I can help to test it when it's available.

@jantman
Copy link
Owner

jantman commented Aug 31, 2020

Please accept my apologies for not responding sooner; I've been quite busy lately and unable to dedicate any time to my open source projects.

Now that these limits are available via Service Quota, this should be much easier to implement.

I can't make any promises on when, or even if, I'll get this implemented myself. But if anyone is willing to implement this, pull requests are greatly appreciated, and there's documentation on how to add support for a new Service.

@sebasrp
Copy link
Contributor

sebasrp commented Oct 1, 2020

I'm working on a pull request for this issue

jantman added a commit that referenced this issue Dec 2, 2020
issue #472 - Add support for AWS EKS service
@jantman
Copy link
Owner

jantman commented Dec 2, 2020

A fix for this issue has been merged to the develop branch and is slated for release in 10.0.0 on Monday, December 7, 2020. Anyone who is able to test the fix is strongly encouraged to do so, and comment on this issue with their results. Instructions for installing awslimitchecker from a git branch are available in the Installing for Development documentation.

jantman added a commit that referenced this issue Dec 2, 2020
@jantman
Copy link
Owner

jantman commented Dec 7, 2020

This has been fixed in 10.0.0, which is now live on PyPI and is being built on the Docker hub right now. Thank you so much for the contribution!

@jantman jantman closed this as completed Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants