Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ElasticCache default limits #488

Closed
sebasrp opened this issue Sep 29, 2020 · 7 comments
Closed

Update ElasticCache default limits #488

sebasrp opened this issue Sep 29, 2020 · 7 comments

Comments

@sebasrp
Copy link
Contributor

sebasrp commented Sep 29, 2020

Bug Report

When reporting a bug in awslimitchecker, please provide all of the following information,
as well as any additional details that may be useful in reproducing or fixing
the issue:

Version

awslimitchecker 9.0.0

Installation Method

Installed through pipenv and executed through python directly

Supporting Software Versions

➜ pipenv run python --version
Python 3.8.5

➜ pipenv --version
pipenv, version 2020.8.13

➜ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.15.6
BuildVersion:	19G2021

Actual Output

➜ awslimitchecker --region ap-southeast-1 -P pd-staging --service ElastiCache --list-defaults
awslimitchecker 9.0.0@9.0.0 is AGPL-licensed free software; all users have a right to the full source code of this version. See <https://github.com/jantman/awslimitchecker>
WARNING:awslimitchecker.trustedadvisor:Cannot check TrustedAdvisor: AWS Premium Support Subscription is required to use this service.
ElastiCache/Nodes                     100
ElastiCache/Nodes per Cluster         20
ElastiCache/Parameter Groups          20
ElastiCache/Security Groups           50
ElastiCache/Subnet Groups             50
ElastiCache/Subnets per subnet group  20

Expected Output

Based on https://docs.aws.amazon.com/general/latest/gr/elasticache-service.html, these limits are no longer accurate and should be:

Limit Current Value New value
ElastiCache/Nodes 100 300
ElastiCache/Nodes per Cluster 20 40 20
ElastiCache/Parameter Groups 20 150
ElastiCache/Security Groups 50
ElastiCache/Subnet Groups 50 150
ElastiCache/Subnets per subnet group 20

TrustedAdvisor

Not Applicable

Testing Assistance

Yes, i will be able to assist in testing pre-release code for the feature.

@sebasrp
Copy link
Contributor Author

sebasrp commented Sep 29, 2020

I am preparing a pull request for this update

@FabianSawatzki1234
Copy link

We ran into the ElastiCache limits as well and it's a false positve. Please merge the pull request.

@jantman
Copy link
Owner

jantman commented Dec 2, 2020

Replied to the PR with a question regarding default limits. I'll get it merged this week. Sorry for the delay.

@sebasrp
Copy link
Contributor Author

sebasrp commented Dec 3, 2020

Seems like the limits I specified in the description should be these updates instead

Limit Current Value New value
ElastiCache/Nodes 100 300
ElastiCache/Nodes per Cluster 20 40 20
ElastiCache/Parameter Groups 20 150
ElastiCache/Security Groups 50
ElastiCache/Subnet Groups 50 150
ElastiCache/Subnets per subnet group 20

@sebasrp
Copy link
Contributor Author

sebasrp commented Dec 3, 2020

updated PR to match this.

jantman added a commit that referenced this issue Dec 7, 2020
issue #488 - Update ElasticCache default limits
jantman added a commit that referenced this issue Dec 7, 2020
@jantman
Copy link
Owner

jantman commented Dec 7, 2020

A fix for this issue has been merged to the develop branch and is slated for release in 10.0.0 on Monday, December 7, 2020. Anyone who is able to test the fix is strongly encouraged to do so, and comment on this issue with their results. Instructions for installing awslimitchecker from a git branch are available in the Installing for Development documentation.

@jantman
Copy link
Owner

jantman commented Dec 7, 2020

This has been fixed in 10.0.0, which is now live on PyPI and is being built on the Docker hub right now. Thank you so much for the contribution!

@jantman jantman closed this as completed Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants