Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in versioncheck if installed inside a git repo #73

Closed
jantman opened this issue Sep 29, 2015 · 1 comment
Closed

bug in versioncheck if installed inside a git repo #73

jantman opened this issue Sep 29, 2015 · 1 comment
Labels
bug

Comments

@jantman
Copy link
Owner

jantman commented Sep 29, 2015

There's a bug in versioncheck if it's installed inside a git repo.

git clone ANYTHING
cd ANYTHING
virtualenv .
pip install awslimitchecker
awslimitchecker -V

This reports the git commit hash and origin URL of ANYTHING.
@jantman jantman added the bug label Sep 29, 2015
jantman added a commit that referenced this issue Nov 16, 2015
@jantman
issue #73 - add regression test for ALC installed inside git repo
86892de
@jantman
Copy link
Owner Author

jantman commented Nov 16, 2015

The tests introduced by 347b061 and the two commits preceding it seem to identify this situation correctly. Now I just need to come up with a plan for how to fix it...

jantman added a commit that referenced this issue Nov 26, 2015
@jantman
issue #73 - begin implementation of property to tell if installed via…
edda4cf 
… git
jantman added a commit that referenced this issue Nov 26, 2015
@jantman
first try at a real fix for #73
87624b7
jantman added a commit that referenced this issue Nov 27, 2015
@jantman
update changelog for #73 fix
d8e5562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jantman