Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Account Attributes for some EC2 limits #84

Closed
jantman opened this issue Oct 23, 2015 · 2 comments
Closed

Use Account Attributes for some EC2 limits #84

jantman opened this issue Oct 23, 2015 · 2 comments
Labels
enhancement
Milestone
0.2.0

Comments

@jantman
Copy link
Owner

jantman commented Oct 23, 2015

Trusted Advisor doesn't provide data for the following EC2 limits:

  • Running On-Demand EC2 instances
  • VPC security groups per elastic network interface
  • EC2-VPC Elastic IPs

However, it appears that these limits are provided in the response to the DescribeAccountAttributes EC2 API call. We should utilize those. Doing so will probably require the introduction of another TA-like limit source, "API", to differentiate between limits that are hard-coded and those which are programmatically retrieved from AWS.
@jantman
Copy link
Owner Author

jantman commented Nov 26, 2015

This requires #88

@jantman jantman added this to the 0.2.0 milestone Nov 27, 2015
jantman added a commit that referenced this issue Nov 28, 2015
@jantman
issue #84 - update docs for Service class _update_limits_from_api() m…
b9545fd 
…ethod
jantman added a commit that referenced this issue Nov 28, 2015
@jantman
issue #84 - add internal support for Service classes with _update_lim…
fbc1c7d 
…its_from_api() methods
jantman added a commit that referenced this issue Nov 28, 2015
@jantman
issue #84 - update documentation/examples for API limits
1f3e2b9
jantman added a commit that referenced this issue Nov 28, 2015
@jantman
Merge pull request #93 from /issues/84
df8648e 
Fixes #84 - use account attributes for some EC2 limits
@jantman
Copy link
Owner Author

jantman commented Nov 28, 2015

Unreleased fix in develop - #93

jantman added a commit that referenced this issue Nov 28, 2015
@jantman
add changelog for issue #84
42b43cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
1 participant
@jantman