-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to Kinesis Firehose delivery streams metric #216
Conversation
For now only Delivery Streams will be analyzed.
Clarify what method should change if more metrics need to be supported.
Current coverage is 99.94% (diff: 100%)@@ develop #216 diff @@
==========================================
Files 22 23 +1
Lines 1665 1679 +14
Methods 0 0
Messages 0 0
Branches 258 254 -4
==========================================
+ Hits 1664 1678 +14
Misses 0 0
Partials 1 1
|
@hltbra I'm so sorry for letting this sit so long. awslimitchecker is purely a personal time project for me, and I haven't had much time to commit to it lately. This looks great to me! Would you mind rebasing on Thanks! |
Used the "Update branch" button, waiting for tests... |
Merging. Thanks so much! Anticipating a release this weekend. |
No problem, @jantman. Thanks for merging these changes! |
This has been released in 0.6.0 and is now live on PyPI |
This pull request creates the service Firehose and implements the metric "'Delivery streams per region".
More information on this limit:
Before submitting pull requests, please see the
Development documentation
and specifically the Pull Request Guidelines.
IMPORTANT: Please take note of the below checklist, especially the first two items.
Pull Request Checklist
writing tests for the code, feel free to ask for help or submit the PR without tests.
tox -e docs
connect()
andconnect_resource()
methods, inherited fromawslimitchecker.connectable.Connectable
if you're working on a GitHub issue (i.e. "issue #x - "). Please
refrain from using the "fixes #x" notation unless you are sure that the
the issue is fixed in that commit.
versioncheck
code, be sure to locally run the-versioncheck
tox tests.Contributor License Agreement
By submitting this work for inclusion in awslimitchecker, I agree to the following terms:
is being made under the same license as the awslimitchecker project (the Affero GPL v3,
or any subsequent version of that license if adopted by awslimitchecker).
this pull request grants a perpetual, global, unlimited license for it to be used and distributed
under the terms of awslimitchecker's license.