Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to Kinesis Firehose delivery streams metric #216

Merged
merged 6 commits into from
Nov 11, 2016

Conversation

hltbra
Copy link
Contributor

@hltbra hltbra commented Oct 18, 2016

This pull request creates the service Firehose and implements the metric "'Delivery streams per region".

More information on this limit:


Before submitting pull requests, please see the
Development documentation
and specifically the Pull Request Guidelines.

IMPORTANT: Please take note of the below checklist, especially the first two items.

Pull Request Checklist

  • All pull requests should be against the develop branch, not master.
  • All pull requests must include the Contributor License Agreement (see below).
  • Code should conform to the Development Guidelines:
    • pep8 compliant with some exceptions (see pytest.ini)
    • 100% test coverage with pytest (with valid tests). If you have difficulty
      writing tests for the code, feel free to ask for help or submit the PR without tests.
    • Complete, correctly-formatted documentation for all classes, functions and methods.
    • documentation has been rebuilt with tox -e docs
    • Connections to the AWS services should only be made by the class's
      connect() and connect_resource() methods, inherited from
      awslimitchecker.connectable.Connectable
    • All modules should have (and use) module-level loggers.
    • Commit messages should be meaningful, and reference the Issue number
      if you're working on a GitHub issue (i.e. "issue #x - "). Please
      refrain from using the "fixes #x" notation unless you are sure that the
      the issue is fixed in that commit.
    • Git history is fully intact; please do not squash or rewrite history.
  • If you made changes to the versioncheck code, be sure to locally run the
    -versioncheck tox tests.

Contributor License Agreement

By submitting this work for inclusion in awslimitchecker, I agree to the following terms:

  • The contribution included in this request (and any subsequent revisions or versions of it)
    is being made under the same license as the awslimitchecker project (the Affero GPL v3,
    or any subsequent version of that license if adopted by awslimitchecker).
  • My contribution may perpetually be included in and distributed with awslimitchecker; submitting
    this pull request grants a perpetual, global, unlimited license for it to be used and distributed
    under the terms of awslimitchecker's license.
  • I have the legal power and rights to agree to these terms.

@codecov-io
Copy link

codecov-io commented Oct 18, 2016

Current coverage is 99.94% (diff: 100%)

Merging #216 into develop will increase coverage by <.01%

@@            develop       #216   diff @@
==========================================
  Files            22         23     +1   
  Lines          1665       1679    +14   
  Methods           0          0          
  Messages          0          0          
  Branches        258        254     -4   
==========================================
+ Hits           1664       1678    +14   
  Misses            0          0          
  Partials          1          1          

Powered by Codecov. Last update 6c0714a...b092c67

@jantman jantman added the ready label Oct 23, 2016
@jantman jantman modified the milestones: 0.5.2, 0.6.0 Oct 26, 2016
@jantman
Copy link
Owner

jantman commented Nov 11, 2016

@hltbra I'm so sorry for letting this sit so long. awslimitchecker is purely a personal time project for me, and I haven't had much time to commit to it lately.

This looks great to me! Would you mind rebasing on develop, and then I'll pull this in for the next release (which should be coming this weekend)?

Thanks!
Jason

@jantman jantman added in progress and removed ready labels Nov 11, 2016
@jantman
Copy link
Owner

jantman commented Nov 11, 2016

Used the "Update branch" button, waiting for tests...

@jantman
Copy link
Owner

jantman commented Nov 11, 2016

Merging. Thanks so much!

Anticipating a release this weekend.

@jantman jantman merged commit 260e280 into jantman:develop Nov 11, 2016
jantman added a commit that referenced this pull request Nov 11, 2016
@hltbra
Copy link
Contributor Author

hltbra commented Nov 11, 2016

No problem, @jantman. Thanks for merging these changes!

@jantman
Copy link
Owner

jantman commented Nov 12, 2016

This has been released in 0.6.0 and is now live on PyPI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants