Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #241 - increase default ElastiCache/Nodes limit from 50 to 100 #242

Merged
merged 1 commit into from
Jan 2, 2017

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 28, 2016

Ref: #241

Pull Request Checklist

  • All pull requests should be against the develop branch, not master.
  • All pull requests must include the Contributor License Agreement (see below).
  • Code should conform to the Development Guidelines:
    • pep8 compliant with some exceptions (see pytest.ini)
    • 100% test coverage with pytest (with valid tests). If you have difficulty
      writing tests for the code, feel free to ask for help or submit the PR without tests.
    • Complete, correctly-formatted documentation for all classes, functions and methods.
    • documentation has been rebuilt with tox -e docs
    • Connections to the AWS services should only be made by the class's
      connect() and connect_resource() methods, inherited from
      awslimitchecker.connectable.Connectable
    • All modules should have (and use) module-level loggers.
    • Commit messages should be meaningful, and reference the Issue number
      if you're working on a GitHub issue (i.e. "issue #x - "). Please
      refrain from using the "fixes #x" notation unless you are sure that the
      the issue is fixed in that commit.
    • Git history is fully intact; please do not squash or rewrite history.
  • If you made changes to the versioncheck code, be sure to locally run the
    -versioncheck tox tests.

Contributor License Agreement

By submitting this work for inclusion in awslimitchecker, I agree to the following terms:

  • The contribution included in this request (and any subsequent revisions or versions of it)
    is being made under the same license as the awslimitchecker project (the Affero GPL v3,
    or any subsequent version of that license if adopted by awslimitchecker).
  • My contribution may perpetually be included in and distributed with awslimitchecker; submitting
    this pull request grants a perpetual, global, unlimited license for it to be used and distributed
    under the terms of awslimitchecker's license.
  • I have the legal power and rights to agree to these terms.

@codecov-io
Copy link

codecov-io commented Dec 28, 2016

Current coverage is 100% (diff: 100%)

Merging #242 into develop will not change coverage

@@           develop   #242   diff @@
=====================================
  Files           22     22          
  Lines         1660   1660          
  Methods          0      0          
  Messages         0      0          
  Branches       256    256          
=====================================
  Hits          1660   1660          
  Misses           0      0          
  Partials         0      0          

Powered by Codecov. Last update d6ebdc2...b0f9e64

@jantman
Copy link
Owner

jantman commented Jan 2, 2017

Thanks so much for this! I'm going to merge it into develop now, though I'm not sure how soon a release will be cut.

@jantman jantman merged commit df7a42b into jantman:develop Jan 2, 2017
jantman added a commit that referenced this pull request Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants