Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicates in IAM Policy #258

Closed
wants to merge 1 commit into from
Closed

Remove duplicates in IAM Policy #258

wants to merge 1 commit into from

Conversation

frioux
Copy link

@frioux frioux commented Mar 10, 2017

There were a bunch of duplicates in the IAM Policy; this fixes that.

Pull Request Checklist

  • All pull requests should be against the develop branch, not master.
  • All pull requests must include the Contributor License Agreement (see below).
  • [na] Code should conform to the Development Guidelines:
    • pep8 compliant with some exceptions (see pytest.ini)
    • 100% test coverage with pytest (with valid tests). If you have difficulty
      writing tests for the code, feel free to ask for help or submit the PR without tests.
    • Complete, correctly-formatted documentation for all classes, functions and methods.
    • documentation has been rebuilt with tox -e docs
    • Connections to the AWS services should only be made by the class's
      connect() and connect_resource() methods, inherited from
      awslimitchecker.connectable.Connectable
    • All modules should have (and use) module-level loggers.
    • Commit messages should be meaningful, and reference the Issue number
      if you're working on a GitHub issue (i.e. "issue #x - "). Please
      refrain from using the "fixes #x" notation unless you are sure that the
      the issue is fixed in that commit.
    • Git history is fully intact; please do not squash or rewrite history.

Contributor License Agreement

By submitting this work for inclusion in awslimitchecker, I agree to the following terms:

  • The contribution included in this request (and any subsequent revisions or versions of it)
    is being made under the same license as the awslimitchecker project (the Affero GPL v3,
    or any subsequent version of that license if adopted by awslimitchecker).
  • My contribution may perpetually be included in and distributed with awslimitchecker; submitting
    this pull request grants a perpetual, global, unlimited license for it to be used and distributed
    under the terms of awslimitchecker's license.
  • I have the legal power and rights to agree to these terms.

@codecov-io
Copy link

codecov-io commented Mar 10, 2017

Codecov Report

Merging #258 into develop will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           develop   #258   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files           23     23           
  Lines         1696   1696           
  Branches       262    262           
======================================
  Hits          1696   1696

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d2fc54...17ee206. Read the comment docs.

@jantman
Copy link
Owner

jantman commented Mar 11, 2017

@frioux I really appreciate the contribution, but those docs are automatically generated from the source itself, specifically with the same method that awslimitchecker --iam-policy uses. I opened #259 for this, and I'll be fixing it soon.

@jantman jantman closed this Mar 11, 2017
@frioux
Copy link
Author

frioux commented Mar 11, 2017 via email

@jantman
Copy link
Owner

jantman commented Mar 11, 2017

@frioux No worries, I'm glad you made me aware of the issue! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants