Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #273 - add support for new i3 instance types #274

Merged
merged 1 commit into from
Jun 4, 2017

Conversation

tamsky
Copy link
Contributor

@tamsky tamsky commented Jun 3, 2017

# pytest awslimitchecker/tests/services/test_ec2.py
=================================== test session starts ===================================
platform darwin -- Python 2.7.13, pytest-3.1.1, py-1.4.33, pluggy-0.4.0
rootdir: [elided]/src/github/awslimitchecker, inifile: pytest.ini
collected 28 items 

awslimitchecker/tests/services/test_ec2.py ............................

================================ 28 passed in 1.13 seconds ================================

Contributor License Agreement

By submitting this work for inclusion in awslimitchecker, I agree to the following terms:

  • The contribution included in this request (and any subsequent revisions or versions of it)
    is being made under the same license as the awslimitchecker project (the Affero GPL v3,
    or any subsequent version of that license if adopted by awslimitchecker).
  • My contribution may perpetually be included in and distributed with awslimitchecker; submitting
    this pull request grants a perpetual, global, unlimited license for it to be used and distributed
    under the terms of awslimitchecker's license.
  • I have the legal power and rights to agree to these terms.

Signed-Off-By: tamsky@users.noreply.github.com Marc Tamsky

@tamsky
Copy link
Contributor Author

tamsky commented Jun 3, 2017

Yes, I sorted the list of instance types in special_limits().

@jantman
Copy link
Owner

jantman commented Jun 3, 2017

@tamsky thanks so much for this! The changes all look good to me, I'm just waiting for Travis to finish the tests. Assuming they're good I'll merge this now, and be targeting a new release in the next 7-8 days or so. I'll try for sooner if I can, but I want to get a few other issues handled in the next release as well.

@jantman
Copy link
Owner

jantman commented Jun 4, 2017

The docs build is failing, but because of a file that wasn't touched in this diff. Merging.

@jantman jantman merged commit 57466c7 into jantman:develop Jun 4, 2017
@tamsky tamsky deleted the add/i3-instance-types branch June 5, 2017 00:49
@tamsky tamsky mentioned this pull request Jun 5, 2017
@jantman
Copy link
Owner

jantman commented Jun 11, 2017

This has been released as 0.9.0 and is now live on PyPI (CHANGELOG).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants