-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CloudTrails service support #350
Merged
jantman
merged 4 commits into
jantman:develop
from
coveord:DT-353/add-cloudtrail-checking
Jul 29, 2018
Merged
CloudTrails service support #350
jantman
merged 4 commits into
jantman:develop
from
coveord:DT-353/add-cloudtrail-checking
Jul 29, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jantman
force-pushed
the
DT-353/add-cloudtrail-checking
branch
from
July 29, 2018 22:40
b4ea1ed
to
9468272
Compare
Codecov Report
@@ Coverage Diff @@
## develop #350 +/- ##
======================================
Coverage 100% 100%
======================================
Files 28 29 +1
Lines 2107 2148 +41
Branches 318 322 +4
======================================
+ Hits 2107 2148 +41
Continue to review full report at Codecov.
|
This was released in 5.0.0 just now, and should be live on PyPI. |
nadlerjessie
pushed a commit
to nadlerjessie/awslimitchecker
that referenced
this pull request
Feb 16, 2019
nadlerjessie
pushed a commit
to nadlerjessie/awslimitchecker
that referenced
this pull request
Feb 16, 2019
nadlerjessie
pushed a commit
to nadlerjessie/awslimitchecker
that referenced
this pull request
Feb 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting pull requests, please see the
Development documentation
and specifically the Pull Request Guidelines.
IMPORTANT: Please take note of the below checklist, especially the first three items.
Summary
Added support for CloudTrails service
Pull Request Checklist
writing tests for the code, that's fine, just mention that in the summary and either
ask for assistance, or clarify that you'd like someone else to handle the tests. PRs that
include complete test coverage will usually be merged faster.
tox -e docs
connect()
andconnect_resource()
methods, inherited fromawslimitchecker.connectable.Connectable
if you're working on a GitHub issue (i.e. "issue #x - "). Please
refrain from using the "fixes #x" notation unless you are sure that the
the issue is fixed in that commit.
Contributor License Agreement
By submitting this work for inclusion in awslimitchecker, I agree to the following terms:
is being made under the same license as the awslimitchecker project (the Affero GPL v3,
or any subsequent version of that license if adopted by awslimitchecker).
this pull request grants a perpetual, global, unlimited license for it to be used and distributed
under the terms of awslimitchecker's license.