Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #477 - ignore shared VPC resources and dedicated/host EC2 instances #484

Merged
merged 3 commits into from
Sep 21, 2020

Conversation

jantman
Copy link
Owner

@jantman jantman commented Sep 21, 2020

This fixes #477

@jantman jantman changed the base branch from master to develop September 21, 2020 17:00
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2020

Codecov Report

Merging #484 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #484   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines         2860      2878   +18     
  Branches       438       441    +3     
=========================================
+ Hits          2860      2878   +18     
Impacted Files Coverage Δ
awslimitchecker/checker.py 100.00% <ø> (ø)
awslimitchecker/services/base.py 100.00% <100.00%> (ø)
awslimitchecker/services/ec2.py 100.00% <100.00%> (ø)
awslimitchecker/services/vpc.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6eef26...3ac96f1. Read the comment docs.

@jantman jantman merged commit c8bb91b into develop Sep 21, 2020
@jantman jantman deleted the issues/477 branch September 21, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Usage for EC2 - on demand vCPU and VPC limits
2 participants